Skip to content

Bugfixes - #95

Open
jacob-williamson wants to merge 2 commits into
mainfrom
fix_bugs
Open

Bugfixes#95
jacob-williamson wants to merge 2 commits into
mainfrom
fix_bugs

Conversation

@jacob-williamson

@jacob-williamson jacob-williamson commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Bugs:

  • After restoring contents after a failed _sync, self._queue was pointing to the same object as self._last_good_contents["queue"] same for queue_history etc. This meant that self._last_good_contents from then on changed whenever self._queue changed, defeating its whole purpose. Fixed by doing a deepcopy
  • i15-1: The queue converter now expects experiment definitions to have a time_per_pdf field, but the background scans inserted by the plugin didn't populate this field. Have added this in based on the max time_per_pdf in the queue, and a test that would have caught this

Also adds some more logging that was helpful when debugging the above

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (28e8839) to head (8ae0bd8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   98.87%   98.88%           
=======================================
  Files          20       20           
  Lines         976      984    +8     
=======================================
+ Hits          965      973    +8     
  Misses         11       11           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant