ViSR: Make Davidia plots fill parent boxes - #164
Draft
Abigail-Yates wants to merge 3 commits into
Draft
Conversation
Collaborator
Author
|
I have got a slight variation on this locally where, for the Tomography view, only the slice view remounts, which could be slightly better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only solution I have found so far that achieves all 3 of these objectives:
The pay off for all 3 of these working is that when the window is resized, the whole React-Grid remounts, so we see a white screen whilst the window resizes and the grid/plots re-render.
This also has added 2 'Box' components around the Heatmap plot in SliceViewer.tsx which might be less ideal for making it a reusable component.
Other solutions I have found have only achieved max 2/3 of the list.