Skip to content

Fix looking at incorrect header word for Standard revision #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstelzer merged 1 commit into from
Sep 1, 2026
Merged

Fix looking at incorrect header word for Standard revision #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,13 @@ Release notes:

1c/03, Lib 1.2.4:

Compiler: Patched over a bug with non-ASCII word separators.
Compiler: patched over a bug with non-ASCII word separators.
The problem isn't really fixed, but it will no longer corrupt
your game text.

Backend: fixed bug with hex colors (#ff8800) on Z-machine
causing problems for older interpreters.

Unit test runner: (game over) and (game over $) are
now overridden in unit.dg, to enable testing of win
conditions.
Expand Down
4 changes: 2 additions & 2 deletions src/runtime_z.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,9 @@ struct rtroutine rtroutines[] = {

// We also need to make sure the Standard revision is 1.1 or higher
// Otherwise, the Z_TRUECOLOR opcode won't exist! And might crash
{Z_LOADW, {SMALL(32), SMALL(0)}, REG_LOCAL+1},
{Z_LOADW, {SMALL(0x32), SMALL(0)}, REG_LOCAL+1},
// Upper byte = major version, lower byte = minor version
// So this needs to be at least 0x0101
// So this needs to be at least $0101

{Z_JL, {VALUE(REG_FGCOLOR), SMALL(0)}, 0, 1}, // Is the foreground color negative? If so, we should do a "standard" setting instead of a "true" setting
{Z_JL, {VALUE(REG_LOCAL+1), LARGE(0x0101)}, 0, 2}, // And if this interpreter doesn't support the Z_TRUECOLOR opcode, we should skip this entirely
Expand Down
Loading