fix(ci): correct Tauri build artifact paths to workspace target/#570
Merged
Conversation
Tauri Build and Release workflows both reference `client/src-tauri/ target/...` for artifact uploads, but the Cargo workspace's actual target directory is at the repo root (`target/...`) because `client/src-tauri` is a workspace member of the root workspace. Effect of the bug: - Tauri Build workflow: builds were successful and Tauri actually bundled `Kaiku_0.1.0_amd64.deb`/`.rpm`/`.AppImage`/`.msi`/`.exe`/ `.dmg`/`.app` at the real path, but the `actions/upload-artifact` glob never matched, silently producing 0 artifacts per run. All recent Tauri Build runs on `main` show "total: 0" in the artifacts list — no client downloads have ever been distributed via CI. - Release workflow: same paths plus `working-directory: client/src- tauri/target` for the codesign/notarize steps. Latent bug — would fail on the first `v*` tag push. Fix: 10 path occurrences across the two files, swapped to `target/` to match the workspace layout. Verified locally that `.cargo/config.toml` has no custom `target-dir` override and Tauri build logs from past runs (e.g., run 25821667446) confirm the artifacts are written to the workspace-root `target/`. After this merges, a fresh Tauri Build on main will upload the `.deb`/`.rpm`/`.AppImage`/`.msi`/`.exe`/`.dmg`/`.app` artifacts to the workflow run, downloadable from the Actions UI or via `gh run download`. Pushing a `v*` tag will then create a real GitHub Release with the binaries attached. Caught while investigating "where are the client downloads?". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug:
tauri-build.ymlandrelease.ymlboth referenceclient/src-tauri/target/...for artifact uploads, but the Cargo workspace's actual target directory is at the repo root (target/...). Theclient/src-tauricrate is a workspace member of the root workspace.Effect:
Kaiku_0.1.0_amd64.deb/.rpm/.AppImage/.msi/.exe/.dmg/.app) at the real path — but theactions/upload-artifactglob never matches, silently producing 0 artifacts per run. No client downloads have ever been distributed via CI.working-directory: client/src-tauri/targetfor codesign/notarize. Latent bug — would have failed on the firstv*tag push.What's actually built (from CI logs, run 25821667446)
What the workflow was looking for:
Fix
Sed across the 10 occurrences in both files:
client/src-tauri/target/→target/. Verified locally:.cargo/config.tomlhas no customtarget-diroverride; Tauri builds in past runs wrote artifacts to the workspace-roottarget/.Test plan
grep -c "client/src-tauri/target"in both files → 0 (verified after fix)main(e.g.,gh workflow run "Tauri Build" --ref main) — artifacts should appear in the run's "Artifacts" sectionv0.1.0-beta.Xtag push exercisesrelease.ymland creates a GitHub Release with binaries attached🤖 Generated with Claude Code