chore(voice): Phase 8 — bump webrtc-rs stack 0.11 → 0.17#567
Draft
Detair wants to merge 2 commits into
Draft
Conversation
WebRTC stack update for the dep-update sweep — the plan's highest-risk
phase, but the actual API migration surface was much smaller than the
6-major version delta suggested.
webrtc 0.11.0 → 0.17.1
webrtc-{ice,dtls,sctp,srtp,data,media,mdns,util} 0.x → 0.17.1
rtp, rtcp, sdp, stun, turn 0.x → 0.17.1
vpx-encode 0.3.0 → 0.6.2
env-libvpx-sys 4 → 5 (+ `generate` feature)
## API migration
### server/src/voice/sfu.rs
`RTCIceServer` lost its `credential_type` field in webrtc-rs 0.15.x
(per the W3C RTCIceServer dictionary, which only defines password
credentials). Removed the explicit field; `..Default::default()` in
callers already produced forward-compatible code at the other
construction site (client/src-tauri/src/webrtc/mod.rs).
### client/src-tauri/vp8-decoder/Cargo.toml
env-libvpx-sys 5.x ships pre-generated FFI bindings only up to libvpx
1.13.0, but modern distros (Arch, Fedora 41+) ship libvpx 1.15/1.16.
Enabled the `generate` feature so bindgen produces bindings against
the installed libvpx headers at build time. Adds no new host-tooling
requirement — bindgen already in the workspace dep tree via other
crates.
## Verification
Locally on Linux (libspa env-mismatch blocks vc-client locally; CI
will validate vc-client on macOS/Windows/Android):
- [x] `cargo build -p vc-server` — clean (46.5s)
- [x] `cargo build -p kaiku-vp8-decoder` — clean
- [x] `cargo clippy -p vc-server -p vc-crypto -p kaiku-vp8-decoder -- -D warnings` — clean
- [x] `cargo test -p vc-crypto` — 22/22 passing
- [x] `cargo test -p kaiku-vp8-decoder` — 4/4 passing
- [x] `cargo deny check` — advisories/bans/licenses/sources all ok
## Deferred (per plan)
- **PLI workaround re-evaluation (Task 8.4)**: not performed. The plan
asks whether `peer.write_rtcp()` reliably delivers in 0.17 (which
would let us drop the interval-PLI workaround in sfu.rs:607-625).
This needs a focused test or live verification — left as a separate
follow-up PR to keep this bump mechanical.
- **Multi-platform canary (Task 8.5)**: out of scope for code changes;
see DRAFT PR checklist.
## Plan deviations
1. Migration surface was 1 line (RTCIceServer field removal) on the
server side — far smaller than the plan's "audit every release note
0.12→0.17 and catalog API breakage in advance" suggested. webrtc-rs
is more API-stable across this delta than the plan anticipated.
2. env-libvpx-sys `generate` feature was not flagged in the plan but
is required against modern libvpx; documented in the Cargo.toml.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
env-libvpx-sys 5.x with the `generate` feature (enabled in the vp8-decoder Cargo.toml because libvpx >= 1.14 has no pre-shipped bindings) runs bindgen against the installed libvpx headers. bindgen needs libclang plus a clang toolchain that can find C stdlib headers (stddef.h etc.); without it the build fails on `vpx_integer.h` → `<stddef.h>` resolution. Three workflow places that compile vp8-decoder on Linux: - ci.yml rust-lint (clippy) - ci.yml rust-test - ci.yml tauri (ubuntu-latest) - tauri-build.yml (ubuntu Tauri build) Added `clang libclang-dev` to each apt install. Windows and macOS Tauri builds use vcpkg / brew toolchains that already bring their own clang, so no change needed there. Caught by the Rust Tests CI run on PR #567 (Phase 8 webrtc bump), which compiled vp8-decoder with the `generate` feature for the first time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Detair
force-pushed
the
chore/webrtc-stack-bump
branch
from
44a593c to
e17784c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT — needs three-client canary before mark-ready
Phase 8 of the dep-update sweep — the plan's highest-risk phase. Surprisingly the API migration surface turned out to be tiny: just one struct field removal on the server side.
Stack updates
webrtcwebrtc-{ice,dtls,sctp,srtp,data,media,mdns,util}rtp,rtcp,sdp,stun,turnvpx-encodeenv-libvpx-sysgeneratefeature)What changed
server/src/voice/sfu.rs—RTCIceServerlost itscredential_typefield in webrtc-rs 0.15.x (per W3C dict, only password creds remain). Removed the explicit field. Client-sideRTCIceServerconstruction already used..Default::default()so it's forward-compatible without changes.client/src-tauri/vp8-decoder/Cargo.toml— enabledenv-libvpx-sysgeneratefeature. v5.x ships bindings only up to libvpx 1.13, but modern distros ship 1.15+. bindgen is already in the workspace tree.Verification (local, on Linux)
cargo build -p vc-server— cleancargo build -p kaiku-vp8-decoder— cleancargo clippy -p vc-server -p vc-crypto -p kaiku-vp8-decoder -- -D warnings— cleancargo test -p vc-crypto— 22/22 passingcargo test -p kaiku-vp8-decoder— 4/4 passingcargo deny check— cleancargo build -p vc-clientcannot complete locally due to a pre-existinglibspa-0.8.0FFI mismatch with the installed PipeWire (same error reproduces onmain). CI's macOS/Windows/Android Tauri builds will catch any vc-client compile issues.Canary checklist (required before mark-ready)
Per the plan, this phase requires a 30-minute three-client canary on
kaiku.pmind.debefore merge:If any anomaly: revert canary, halt, file an issue.
Deferred follow-ups
peer.write_rtcp()reliably delivers in 0.17 (which would let us drop the interval-PLI workaround inserver/src/voice/sfu.rs:607-625). Needs a focused test or live verification. Left as a separate PR to keep this bump mechanical.cargo auditre-run after merge — thebincode 1advisory may clear via webrtc-dtls 0.17's bumped pin. Document delta.Plan deviations
env-libvpx-sysgeneratefeature wasn't flagged in the plan but is required against modern libvpx 1.15+.🤖 Generated with Claude Code