Skip to content

chore(client): Phase 6c — bump jsdom + marked + @types/node#562

Merged
Detair merged 1 commit into
mainfrom
chore/jsdom-marked-types-node-bump
May 12, 2026
Merged

chore(client): Phase 6c — bump jsdom + marked + @types/node#562
Detair merged 1 commit into
mainfrom
chore/jsdom-marked-types-node-bump

Conversation

@Detair

@Detair Detair commented May 12, 2026

Copy link
Copy Markdown
Owner

Summary

Phase 6c of the dependency-update sweep (docs/superpowers/plans/2026-05-08-dependency-update-implementation.md). Three test-infrastructure majors:

Package From To
jsdom ^27.4.0 ^29.1.1 (2 majors)
marked ^17.0.6 ^18.0.3 (1 major)
@types/node ^22.19.18 ^25.7.0 (3 majors)

@types/node moved 3 majors because the spec's original 24.12.3 target shipped and 25 went stable in the meantime. Per the plan's "re-query at PR time" rule (use registry latest if ≥ spec target), pinning to 25.7.0. Types-only — no runtime impact from the Node version delta.

Zero source-code fixes needed

  • bun run build — clean (tsc + vite, 5.87s)
  • bun run test:run — 581/581 passing
  • marked v18 renderer-extension API (used in spoilerExtension.ts, MessageItem.tsx, MarkdownPreview.tsx) is unchanged on our usage surface
  • jsdom v29 DOM strictness didn't break any test (32/32 files green)

Note on remote routine

The Phase 6c remote routine fired on schedule (2026-05-11T18:15Z) but correctly aborted: the plan's baseline gate required @types/node to equal ^22.15.0, and PR #549 (Phase 1 within-bound housekeeping) had already bumped it to ^22.19.18. Running manually with the looser "re-query at PR time" rule.

Open follow-up (separate PR)

bun run lint is broken on main since the TS 6 bump (#555). Two distinct bugs in the chain: eslint-plugin-solid subpath import (needs .js suffix removed) and brace-expansion override resolving to 1.x where minimatch needs 5.x's named export. Out of scope for this PR; CI doesn't run lint anyway. Tracking issue to follow.

Spec

docs/superpowers/specs/2026-05-08-dependency-update-design.md (Phase 6c).

Test plan

  • bun run build clean
  • bun run test:run — 581/581 passing
  • marked usage in renderer/spoiler extensions verified unchanged
  • Manual: chat message rendering with markdown / spoilers after deploy
  • Manual: vitest jsdom-backed component tests in CI green

🤖 Generated with Claude Code

Test-infrastructure majors for the dep-update sweep:

  jsdom        ^27.4.0   → ^29.1.1   (2 majors)
  marked       ^17.0.6   → ^18.0.3   (1 major)
  @types/node  ^22.19.18 → ^25.7.0   (3 majors)

@types/node moved 3 majors because the spec's original 24.12.3 target
shipped, and 25 went stable in the meantime. Per plan's "re-query at
PR time" rule (use registry if >= spec target), pinning to 25.7.0.
Types-only — no runtime/build impact from the Node version delta.

Zero source-code fixes needed:
- `bun run build` clean (tsc + vite)
- `bun run test:run` — 581/581 passing
- marked v18 renderer-extension API (used in spoilerExtension.ts +
  MessageItem.tsx + MarkdownPreview.tsx) is unchanged on our usage
  surface — no port required.
- jsdom v29 DOM strictness didn't break any test (32/32 files green).

The remote routine fired for Phase 6c on 2026-05-11T18:15Z but
aborted because the plan's baseline gate required @types/node
to equal ^22.15.0, and PR #549 (within-bound housekeeping) had
already lifted it to ^22.19.18. Running manually with the looser
"re-query at PR time" rule.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Detair Detair merged commit 360af06 into main May 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant