refactor(infra): Phase 4c — bump zip 2 → 8 (server export)#553
Merged
Conversation
Phase 4c of the dep-update sweep. zip rewrote its 2.x → 3.x API but
preserved the surface we use (SimpleFileOptions, ZipWriter::new,
start_file, finish), so the bump is zero source-change.
Workspace dep:
zip = { version = "2", default-features = false, features = ["deflate"] }
→ zip = { version = "8", default-features = false, features = ["deflate-flate2"] }
Feature rename: zip 8 split the old `deflate` umbrella into
`deflate-flate2` (matches our prior behavior — flate2-based deflate
with miniz_oxide) and `deflate-zopfli` (slow, output-optimal). We
pick `deflate-flate2` to preserve write performance for the data
export endpoint.
The single consumer is server/src/governance/export.rs (GDPR data
export ZIP archive). Its 14 start_file calls + finish() compile and
round-trip behavior is covered by the existing
test_request_data_export_no_s3 integration test (runs in CI).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4c of the dep-update sweep (spec, plan). Builds on Phase 4a (#552).
ziprewrote its 2.x → 3.x API but preserved the surface we use (SimpleFileOptions,ZipWriter::new,start_file,finish), so the bump is zero source-change.Workspace dep
Feature rename
zip 8split the olddeflateumbrella intodeflate-flate2(matches our prior behavior — flate2-based deflate with miniz_oxide) anddeflate-zopfli(slow, output-optimal compression). We pickdeflate-flate2to preserve write performance for the data-export endpoint.Single consumer
server/src/governance/export.rs(GDPR data export ZIP archive). 14start_filecalls +finish(). Round-trip behavior is covered by the existingtest_request_data_export_no_s3integration test.Test plan
cargo fmt --check— cleancargo clippy --tests -p vc-server -- -D warnings— cleancargo deny check—advisories ok, bans ok, licenses ok, sources okcargo audit— exit 0 with established ignore listcargo build --tests -p vc-server— cleancargo check -p vc-serverafter rebase onto main — cleantest_request_data_export_no_s3integration test — runs in CI (DB-dependent, can't run locally)🤖 Generated with Claude Code