stash it#2
Open
JackDoan wants to merge 1 commit into
Open
Conversation
johnmaguire
added a commit
that referenced
this pull request
Jul 1, 2026
…hange) On a client-side-cache miss, the goroutine that performed the fetch is handed the raw server reply, not the stored entry, so a CachePut right after the miss wrote to a nil stash and was dropped -- the caller then re-parsed the same response on the very next hit (one wasted decode per fill). pipe.go now allocates one cacheStash per fill and shares its pointer between the copy stored in the entry and the reply returned to the fetcher, so CachePut lands and later hits read it. Update() keeps a pre-seeded stash instead of reallocating (composes with PR #2's guard); the CacheStore interface is unchanged. Adds TestClientSideCachingStashSurvivesMiss (fails without the pipe seeding), which also asserts a refill after invalidation starts with a fresh stash. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.