Skip to content

Additional possible detector systematics for SBND - #34

Merged
francois-drielsma merged 2 commits into
DeepLearnPhysics:mainfrom
jzettle:feature/jzettle_updated_modifier
Aug 20, 2026
Merged

Additional possible detector systematics for SBND#34
francois-drielsma merged 2 commits into
DeepLearnPhysics:mainfrom
jzettle:feature/jzettle_updated_modifier

Conversation

@jzettle

@jzettle jzettle commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Adding a few examples for possible additional detector systematics for SBND, a +/- 5% gain variation, and making the response function smearing to 15% instead of 5%. These were all tested at NERSC and validated to work

@francois-drielsma

Copy link
Copy Markdown
Member

Cleaned up the three SBND detector-systematic modifiers: corrected the gain filenames to the six-digit 260818 version, fixed the negative modifier identity, normalized YAML formatting/comments/descriptions, added reciprocal gain-variation conflict metadata, and clarified that the 15% smearing modifier intentionally retains the central response correction. All three fully resolve against full_chain_co_260316; local pre-commit and configuration-validation checks pass.

@francois-drielsma francois-drielsma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after correcting the versioned filenames and negative-gain identity, harmonizing the YAML metadata and formatting, and validating all three modifiers against the SBND full-chain configuration.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6d3a9c6) to head (22699c4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1319      1319           
=========================================
  Hits          1319      1319           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@francois-drielsma
francois-drielsma merged commit b554cd8 into DeepLearnPhysics:main Aug 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants