Update charge scale parameters - #33
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1319 1319
=========================================
Hits 1319 1319 🚀 New features to boost your workflow:
|
…rgescale_params' into feature/updated_chargescale_params
|
Updated the ICARUS charge-scale modifier to add only the response and smearing calibration stages, with priorities 10/9 so they run before the existing charge calibrations. Added a model >=250303 compatibility gate because earlier ICARUS models do not have in-chain calibration, plus resolved-config regression coverage. Also removed the trailing whitespace that was failing pre-commit. Full local configuration validation and pre-commit pass. |
francois-drielsma
left a comment
There was a problem hiding this comment.
Approved after narrowing the ICARUS override to response/smearing, preserving the base calibration, gating compatibility at model >=250303, and adding regression coverage.
This PR updates the charge scale parameters and adds smearing as an option. This requires SPINE version >0.17.0 to include all the necessary elements.