Skip to content

Update charge scale parameters - #33

Merged
francois-drielsma merged 12 commits into
DeepLearnPhysics:mainfrom
jzettle:feature/updated_chargescale_params
Aug 15, 2026
Merged

Update charge scale parameters#33
francois-drielsma merged 12 commits into
DeepLearnPhysics:mainfrom
jzettle:feature/updated_chargescale_params

Conversation

@jzettle

@jzettle jzettle commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

This PR updates the charge scale parameters and adds smearing as an option. This requires SPINE version >0.17.0 to include all the necessary elements.

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (35bdde8) to head (014f8ff).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1319      1319           
=========================================
  Hits          1319      1319           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@francois-drielsma

Copy link
Copy Markdown
Member

Updated the ICARUS charge-scale modifier to add only the response and smearing calibration stages, with priorities 10/9 so they run before the existing charge calibrations. Added a model >=250303 compatibility gate because earlier ICARUS models do not have in-chain calibration, plus resolved-config regression coverage. Also removed the trailing whitespace that was failing pre-commit. Full local configuration validation and pre-commit pass.

@francois-drielsma francois-drielsma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after narrowing the ICARUS override to response/smearing, preserving the base calibration, gating compatibility at model >=250303, and adding regression coverage.

@francois-drielsma
francois-drielsma merged commit 451192c into DeepLearnPhysics:main Aug 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants