Skip to content

DB and config for sbnd gen2 data - #31

Open
seokjuchung wants to merge 1 commit into
DeepLearnPhysics:mainfrom
seokjuchung:sbnd_gen2
Open

DB and config for sbnd gen2 data#31
seokjuchung wants to merge 1 commit into
DeepLearnPhysics:mainfrom
seokjuchung:sbnd_gen2

Conversation

@seokjuchung

Copy link
Copy Markdown

DB and config for sbnd gen2 data

@francois-drielsma

Copy link
Copy Markdown
Member

Thanks for this contribution. We have prototyped the integration on pr31-prototype (commit 05930ab) with the following structure:

  • The default SPINE release moves to v0.17.1.
  • The two full configurations and bundled calibration files are replaced by a versioned data:260501 modifier.
  • The lifetime and YZ maps are read from $SBND_DATA_DIR/v01_42_00 rather than copied into this repository.
  • The modifier applies the requested gain, lifetime database keys/scale, and YZ correction inside the model, before segmentation.
  • Compatibility is split at 260501: the new modifier requires model/post configurations with in-model calibration, while older data modifiers require configurations with post-processing calibration.

We have not carried over the no-calibration configuration yet. Could you clarify its intended use? Is it needed for a specific production output, or is it primarily an A/B validation against the newly calibrated processing?

Would the current single production data modifier be sufficient? If the uncalibrated comparison is required, we can add an explicitly named data_nocalib modifier once the use case is clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants