fix parsing of bare open: do not load modules as require open does#1450
Merged
Conversation
A bare open (not preceded by require) was parsed as require open since the LL(1) parser rework (Deducteam#1441), silently loading not yet required modules instead of failing, and pretty-printing back as require open.
Collaborator
|
Yes, my bad! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the LL(1) parser rework (#1441, 078dba4), a bare
[private] open M;is parsed asP_require(Some private?, ...)— the same AST asrequire [private] open M;. Consequently:open M;silently requiresMwhen it is not yet loaded, instead of failing withModule "M" needs to be required first.—Handle.Command.handle_openbecame unreachable, since no parser constructedP_openanymore;open M;back asrequire open M;.This PR restores
P_openfor the bare forms (open,private open), keepsP_requirefor therequireforms, and adds a KO test (openof a module that was not required). No change to the grammar itself.