Skip to content

apply: re-strip trailing hyphen after slice so slugify is idempotent #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

apply: re-strip trailing hyphen after slice so slugify is idempotent #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions components/sections/apply-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ const slugify = (s: string): string =>
.replace(/[^a-z0-9]+/g, "-")
.replace(/^-+|-+$/g, "")
.slice(0, 32)
// Re-strip a trailing hyphen if the 32-char cap landed on one. Without
// this second pass, slugify is non-idempotent — `slugify(slugify(x))`
// can differ from `slugify(x)`, which silently breaks the
// `state.slug === slugify(state.slug)` advance check below.
.replace(/-+$/g, "")

export function ApplyForm() {
const [state, setState] = useState<FormState>({
Expand Down