Fix provider config crash after 1.0.17 migration - #226
Open
vallembreuse wants to merge 18 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a startup crash affecting provider configurations migrated by the 1.0.17 typed-provider migration.
Observed exception:
java.lang.IllegalArgumentException: Configuration payload does not match stored provider typeRoot cause
The 1.0.17 provider migration stores the provider type in the
provider_configs.typecolumn, while migratedencrypted_config_jsonpayloads can omit the correspondingtypefield.When Gson deserializes one of these migrated payloads into a Kotlin provider configuration class, the body-property initializer for
typemay not run. The existing codec then compares this value with the stored provider type and throws.Fix
type.copy()so its Kotlintypeproperty is initialized normally.type: a real mismatch still throws.Tests
Added a regression test covering migrated payloads without embedded
typefor:The targeted provider configuration tests pass.
Device validation
A debug build containing the patch was tested on a Redmi Pad 2 Pro running Android 16 / HyperOS 3.
Validated successfully:
The debug build uses a separate application data sandbox, so the historical migrated database scenario is covered by the regression test rather than direct access to the official app's private database.