fix(epg): chunk native-program lookup to stay under SQLite's variable… - #223
Open
marcoeg wants to merge 1 commit into
Open
fix(epg): chunk native-program lookup to stay under SQLite's variable…#223marcoeg wants to merge 1 commit into
marcoeg wants to merge 1 commit into
Conversation
… cap resolveForProvider passed every channel's epgChannelId as a bind variable to a single IN (...) query. On Android <= 11 (SQLite < 3.32) SQLITE_MAX_VARIABLE_NUMBER is 999, so any provider with 1,000+ channels fails EPG import with "too many SQL variables" — reproduced on an NVIDIA SHIELD (Android 11) with a 1,080-channel M3U. Chunk at 500, mirroring the pattern already used at every sibling call site (EpgRepositoryImpl.getPrograms*/getNowPlaying*, EpgResolutionEngine's mapping/programme lookups) — this was the last un-chunked channel-list query. Adds a regression test asserting the chunk sizes (500 + 100 for 600 channels) and id coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… cap
resolveForProvider passed every channel's epgChannelId as a bind variable to a single IN (...) query. On Android <= 11 (SQLite < 3.32) SQLITE_MAX_VARIABLE_NUMBER is 999, so any provider with 1,000+ channels fails EPG import with "too many SQL variables" — reproduced on an NVIDIA SHIELD (Android 11) with a 1,080-channel M3U.
Chunk at 500, mirroring the pattern already used at every sibling call site (EpgRepositoryImpl.getPrograms*/getNowPlaying*, EpgResolutionEngine's mapping/programme lookups) — this was the last un-chunked channel-list query. Adds a regression test asserting the chunk sizes (500 + 100 for 600 channels) and id coverage.