Add read-only Expo ballot spike - #62
Merged
DavidMoritz merged 2 commits intoAug 9, 2026
Merged
Conversation
ejones23
force-pushed
the
codex/expo-readonly-ballot
branch
from
August 8, 2026 20:51
98f7a09 to
76a39dd
Compare
ejones23
marked this pull request as ready for review
August 8, 2026 20:58
DavidMoritz
approved these changes
Aug 9, 2026
DavidMoritz
left a comment
DavidMoritz
left a comment
Owner
There was a problem hiding this comment.
The typed adapter layer is really well done — love how you handled all the PDO string quirks and the plain-text error responses from the PHP side. The discriminated union for load states and the AbortController cleanup show a lot of care. This is exactly the kind of compatibility seam that's going to make the migration smooth. Great work!
DavidMoritz
force-pushed
the
codex/expo-readonly-ballot
branch
from
August 9, 2026 00:10
76a39dd to
1801d8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top layer of native stacked PR #64; depends on #61. Adds a typed compatibility adapter for get-candidates.php, runtime normalization of legacy PDO values, stable error codes, API base URL configuration, six adapter tests, and a read-only ballot detail screen with loading, retry, closed, missing, malformed-response, and network states. No vote submission, authentication, API endpoint, database, or deployment changes. Checks: 8 mobile tests, TypeScript, Expo lint/export, 188 legacy Vitest tests, 205 PHPUnit tests, and the legacy production build.