feat: add feedback banner and issue links to errors - #57
Merged
Conversation
OData services, Datasphere tenants and Business Central instances differ by version and auth setup in ways we cannot reproduce here, so the users who hit a problem are the only ones who can tell us what their setup looked like. A once-a-day banner on interactive load, from the shared DataZooDE/duckdb-extension-banner submodule. Silent when piped, in notebooks, in CI and under the test runner, so no existing expected output changes. An issue link on errors from the registered functions -- 101 scan and bind pointers across the OData, Datasphere, Business Central, Graph and ODP surfaces -- via DATAZOO_GUARD. Branched from main rather than stacked on migrate/datazoo-oauth2 so the two can merge in either order. Verified against the built artifact: banner on an interactive LOAD, absent when piped, and a failing odata_read reporting its original Invalid Input Error with the link appended. C++ suite green at 1141 assertions in 226 cases -- the same numbers as before this change.
On MinGW the 'struct _stat64' tag hides the function of the same name in C++, so the banner's _stat64 call parsed as a constructor and every rtools/MinGW Windows job failed to compile. The shared library now uses plain stat() everywhere except MSVC. Caught by anofox-similarity CI, which builds windows_amd64_rtools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OData services, Datasphere tenants and Business Central instances differ by version and auth setup in ways we cannot reproduce here, so the users who hit a problem are the only ones who can tell us what their setup looked like.
This completes a fleet-wide rollout using the shared
DataZooDE/duckdb-extension-bannersubmodule — erpl-adt and erpl-rev are released, the rest are in review.What changed
Once-a-day banner on interactive load. Silent when piped, in notebooks, in CI and under the test runner — which is why no existing expected output changes.
Issue link on errors from 101 scan/bind pointers across the OData, Datasphere, Business Central, Graph and ODP surfaces, via
DATAZOO_GUARD.Branched from main, not stacked on the migration
This is deliberately not built on
migrate/datazoo-oauth2(#56), so the two can merge in either order without a rebase dance.Verified against the built artifact
LOAD, absent when pipedodata_readreports its originalInvalid Input Errorwith the link appendedNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.