Main dev#166
Merged
Merged
Conversation
- Quote torch>=1.13.0 to prevent shell redirection - Fixes the mysterious =1.13.0 file creation bug caused by unquoted >= operator This aligns with the fix in the parent SAGE repository for numpy>=2.0.0
Add modern build configuration for publishing LibAMM to PyPI as isage-libamm: Features: - Package name: isage-libamm (PyPI) - Import name: PyAMM (Python) - Version: 0.1.1 - Build system: scikit-build-core + pybind11 - Runtime deps: numpy>=1.20.0, torch>=2.0.0 Publishing: - Pre-compiled platform-specific wheels - CPU-only and CUDA variants - Compatible with sage-libs dependency chain Usage: pip install isage-libamm Related: #pypi-publishing #libamm-standalone
- 移除算法实现代码（已迁移到 SAGE/sage-libs/amms） - 移除构建系统和配置文件（CMakeLists.txt, setup.py, pyproject.toml） - 移除算法测试代码（test/） - 移除第三方依赖（thirdparty/） - 保留完整的 Benchmark 框架（benchmark/） - 保留数据管理工具（tools/） - 更新 README 说明新的仓库定位 算法实现现已位于: - SAGE Framework: intellistream/SAGE - Package: sage-libs/src/sage/libs/amms/ - PyPI: pip install isage-amms 此仓库现专注于 AMM 算法的性能评测和基准测试。 Backup branch: backup-before-refactor-20260102-095815
- 添加 requirements.txt 声明 benchmark 依赖 - 说明需要安装 isage-amms 包（AMM 算法实现） - 提供从 PyPI 和 SAGE 源码两种安装方式 - 添加 INSTALLATION.md 详细安装指南 - 删除临时重构脚本（已在 .gitignore 中）
There was a problem hiding this comment.
Pull request overview
This pull request removes a significant portion of the LibAMM codebase, deleting multiple source files, headers, and build configurations. The changes appear to be part of a major refactoring or cleanup effort.
- Complete removal of matrix loader implementations (Beta, Random, Gaussian, SIFT, MNIST, etc.)
- Deletion of all C++ algorithm implementations (CRS, CountSketch, INT8, TugOfWar, etc.)
- Removal of parallelization and streaming components
- Elimination of utility classes (ThreadPerf, ConfigMap, IntelliLog, etc.)
- Deletion of build configuration files (setup.py, CMakeLists.txt)
Reviewed changes
Copilot reviewed 119 out of 2799 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/MatrixLoader/*.cpp | Removed all matrix loader implementations |
| src/CPPAlgos/*.cpp | Deleted all C++ algorithm implementations |
| src/CPPAlgos/CMakeLists.txt | Removed CMake build configuration for algorithms |
| src/CMakeLists.txt | Deleted main source directory build configuration |
| src/CL/*.cl | Removed OpenCL kernel implementations |
| setup.py | Deleted Python package setup and build configuration |
| include/Utils/*.hpp | Removed utility class headers |
| include/MatrixLoader/*.h | Deleted matrix loader header files |
| include/CPPAlgos/*.h | Removed algorithm header files |
| include/Streaming/*.h | Deleted streaming component headers |
| include/Parallelization/*.h | Removed parallelization infrastructure |
| include/*.h.in | Deleted configuration template headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.