Switch druid_cube materialization SQL generation to v3 build path + support FULL strategy#2102
Merged
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the v2
get_measures_querycall inbuild_cube_materializationwith the v3build_measures_sqlbuilder, bringing cube materialization SQL generation in line with the rest of the v3 query path. It adds two adapters:_v3_grain_group_to_measures_queryand_v3_col_to_model_columnthat bridge v3'sGrainGroupSQLoutput into the existingMeasuresMaterializationshape, so that downstream combiner/Druid config logic is unchanged.It also fixes the
FULLstrategy: temporal partition filters are now only injected forINCREMENTAL_TIME;FULLmaterialization runs scan the full upstream as expected. Cube-level static filters still apply for both strategies.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan