feat(datadog-agent-commons): add minimal IPC TLS feature - #2360
Conversation
Binary Size Analysis (Agent Data Plane)Baseline: f78be12 · Comparison: d6aff00 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
There was a problem hiding this comment.
More details
The ipc-tls feature enables every dependency required by the exposed TLS module, while the default full feature preserves the crate’s existing API and dependency behavior.
🤖 Datadog Autotest · Commit d6aff00 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Summary
Add an
ipc-tlsfeature todatadog-agent-commonsso consumers can use the Agent IPC mTLS helpers without pulling the whole dependency graph.The existing behavior remains the default through a
fullfeature. Withdefault-features = falseandfeatures = ["ipc-tls"], the dependency graph is limited to Rustls,saluki-tls,saluki-error, and Tokio.Change Type
How did you test this PR?
I integrated this into a feature I'm building to make sure it loads ok and the functionality works as intended. See
DataDog/datadog-agent#54592 (extremely draft PR)
make fmtcargo check -p datadog-agent-commons --no-default-featurescargo check -p datadog-agent-commons --no-default-features --features ipc-tlscargo test -p datadog-agent-commons --no-default-features --features ipc-tlscargo test -p datadog-agent-commons