fix(sidecar): configure OTLP endpoint for FFE metrics#2076
Open
leoromanovsky wants to merge 3 commits into
Open
fix(sidecar): configure OTLP endpoint for FFE metrics#2076leoromanovsky wants to merge 3 commits into
leoromanovsky wants to merge 3 commits into
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 091c98d | Docs | Datadog PR Page | Give us feedback! |
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🔒 Cargo Deny Results📦
|
leoromanovsky
changed the title
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2076 +/- ##
==========================================
+ Coverage 73.43% 73.47% +0.03%
==========================================
Files 470 470
Lines 78340 78357 +17
==========================================
+ Hits 57532 57571 +39
+ Misses 20808 20786 -22
🚀 New features to boost your workflow:
|
leoromanovsky
requested review from
dd-oleksii,
sameerank and
typotter
and removed request for
a team and
typotter
leoromanovsky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Companion PHP evaluation-metrics work needs FFE metrics to follow the sidecar architecture used by the rest of the tracer: configure endpoints once on the session, then send typed sidecar actions without carrying endpoint strings on every flush.
The previous FFE metrics path accepted an OTLP endpoint alongside each metrics batch. That diverged from the normal
Endpointflow, made test-session-token propagation easy to miss, and forced PHP to keep fetching endpoint configuration during request flushes.Design context: https://docs.google.com/document/d/1NvMfTpZWLBlFmEFNjdnlMyeVpy5l7KD8qujGFco6w2w/edit?tab=t.0
Companion PHP PR: DataDog/dd-trace-php#3911
Changes
Endpointto sidecar session configuration.ddog_sidecar_session_set_configand session state.SidecarAction::FfeEvaluationMetricsthrough the session's configured OTLP metrics endpoint instead of an endpoint passed with each metrics batch.test_tokenwhen the OTLP metrics endpoint does not already have one.x-datadog-test-session-tokenthroughEndpointstandard headers.Decisions
FFE metrics remain caller-driven. This PR does not make shared evaluator calls auto-emit metrics, so SDKs that still log metrics in host language implementations can continue to coexist without double counting.
The sidecar owns metrics transport, aggregation, OTLP/protobuf encoding, and endpoint/header handling. PHP remains responsible for constructing the appropriate OTLP metrics endpoint from its existing configuration resolver and supplying it once during sidecar session setup.
The test-session-token behavior is intentionally implemented through
Endpoint, not by manually adding FFE-specific headers. Production endpoints normally have no test token, so production behavior is unchanged.Validation
Local targeted test:
cargo test -p datadog-sidecar ffe_metric_actions_dispatch_without_registered_applicationResult: passed locally.
Negative validation during review:
Endpoint.test_tokenfails with a missingx-datadog-test-session-tokenheader.Endpointstandard headers.CI on commit
091c98dreports all tests passed and no new flaky tests.