Fix race condition in documentation team approval check#35946
Merged
hestonhoffman merged 2 commits intomasterfrom Apr 13, 2026
Merged
Fix race condition in documentation team approval check#35946hestonhoffman merged 2 commits intomasterfrom
hestonhoffman merged 2 commits intomasterfrom
Conversation
When cancel-in-progress cancels the upstream check job, its outputs are empty strings. The update-pr-status job (which runs with if: always()) was interpreting empty outputs as "team not requested", incorrectly posting a success status that overwrote a previous valid failure. Skip the status update when outputs are empty so cancelled runs don't clobber earlier results.
devindford
approved these changes
Apr 13, 2026
hestonhoffman
deleted the
hestonhoffman/fix-approval-check-race-condition
branch
StefonSimmons
pushed a commit
that referenced
this pull request
Apr 16, 2026
When cancel-in-progress cancels the upstream check job, its outputs are empty strings. The update-pr-status job (which runs with if: always()) was interpreting empty outputs as "team not requested", incorrectly posting a success status that overwrote a previous valid failure. Skip the status update when outputs are empty so cancelled runs don't clobber earlier results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Fixes a race condition in the
codeowner_review_status.ymlworkflow where a cancelled upstream job causes theupdate-pr-statusjob to incorrectly post a success status.Root cause: The workflow uses
cancel-in-progress: trueon its concurrency group. When a new run cancels an in-flight run, thecheck-documentation-team-approvaljob is cancelled and produces no outputs. Theupdate-pr-statusjob runs anyway (due toif: always()) and interprets the empty outputs as "documentation team not requested", posting a success commit status that overwrites the previous valid failure status.This was observed on #35941, where the approval check passed despite no documentation team member approving.
Fix: Skip the status update entirely when upstream outputs are empty, so cancelled runs don't clobber earlier valid results.
Merge instructions
Merge readiness:
Additional notes