Skip to content

chore(symbol-db): refresh metadata after identity refresh - #19824

Draft
litianningdatadog wants to merge 1 commit into
tianning.li/2-flask-web-request-starting-eventfrom
tianning.li/3-7-symbol-db-identity-refresh
Draft

chore(symbol-db): refresh metadata after identity refresh#19824
litianningdatadog wants to merge 1 commit into
tianning.li/2-flask-web-request-starting-eventfrom
tianning.li/3-7-symbol-db-identity-refresh

Conversation

@litianningdatadog

Copy link
Copy Markdown
Contributor

Description

Split from #19780.

Symbol DB metadata includes runtime identity. Refresh that metadata after runtime identity changes so Symbol DB events emitted after a MicroVM /run refresh use the new runtime id.

Testing

  • scripts/lint format_check ddtrace/internal/symbol_db/symbols.py tests/internal/symbol_db/test_symbols.py
  • git diff --check

Stack

Draft split branch. Stacked on #19816.

@litianningdatadog litianningdatadog added changelog/no-changelog A changelog entry is not required for this PR. aws-microvm Work related to AWS MicroVM onboarding labels Aug 23, 2026
@litianningdatadog litianningdatadog changed the title fix(symbol-db): refresh metadata after identity refresh chore(symbol-db): refresh metadata after identity refresh Aug 23, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Aug 23, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 26b013a | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 23, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-23 22:26:19

Comparing candidate commit 26b013a in PR branch tianning.li/3-7-symbol-db-identity-refresh with baseline commit d59e112 in branch tianning.li/2-flask-web-request-starting-event.

📊 Benchmarking dashboard

Found 0 performance improvements and 11 performance regressions! Performance is the same for 610 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-wsgi_valid_headers_all

  • 🟥 execution_time [+395.768ns; +462.411ns] or [+7.202%; +8.414%]

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.956µs; +2.154µs] or [+10.195%; +11.225%]

scenario:iastaspects-add_aspect

  • 🟥 execution_time [+15.692µs; +18.816µs] or [+15.427%; +18.497%]

scenario:iastaspects-join_aspect

  • 🟥 execution_time [+46.896µs; +51.348µs] or [+22.140%; +24.242%]

scenario:iastaspects-ljust_noaspect

  • 🟥 execution_time [+61.934µs; +65.922µs] or [+21.688%; +23.085%]

scenario:iastaspects-title_aspect

  • 🟥 execution_time [+60.649µs; +66.587µs] or [+22.519%; +24.723%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+142.108µs; +149.038µs] or [+34.747%; +36.442%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+18.653µs; +21.930µs] or [+12.928%; +15.199%]

scenario:span-start

  • 🟥 execution_time [+1.346ms; +1.505ms] or [+8.858%; +9.910%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+427.897ns; +477.933ns] or [+15.884%; +17.741%]

scenario:tracer-small

  • 🟥 execution_time [+27.479µs; +29.398µs] or [+8.154%; +8.723%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-667.684ns; +815.879ns] or [-6.050%; +7.393%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-35.575ns; +30.447ns] or [-5.797%; +4.961%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1664.037ns; +1666.709ns] or [-9.718%; +9.733%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1216.680ns; +1229.665ns] or [-9.467%; +9.568%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-337.450ns; +317.210ns] or [-9.158%; +8.608%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-281.746ns; +227.377ns] or [-9.606%; +7.753%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-86.583ns; +59.350ns] or [-7.554%; +5.178%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-3492.306ns; +4357.123ns] or [-8.731%; +10.893%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-724.479ns; +839.686ns] or [-8.978%; +10.406%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-56.774µs; +63.180µs] or [-8.884%; +9.886%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-microvm Work related to AWS MicroVM onboarding changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant