feat(process-tags): Service Override Source Attribution#3948
Draft
Leiyks wants to merge 4 commits into
Draft
Conversation
…svc_src) Implements the RFC "Service Override Source Attribution": tags every span whose service was actively chosen (vs. tracer's default) with a `_dd.svc_src` meta value identifying the source. Cleared for the default case (DD_SERVICE-set or auto-resolved). Sources emitted, per RFC categories: - `<integration_name>` — when the integration sets the service (Curl, Guzzle, PDO, Mysqli, SQLSRV, MongoDB, Memcached, AMQP, Kafka, ... via `Integration::handleInternalSpanServiceName`) - `opt.<option>` — when a config-driven split changes the service: * `opt.http_client_split_by_domain` (Curl, Guzzle, Psr18, Ratchet) * `opt.db_client_split_by_instance` (PDO, Mysqli, SQLSRV) * `opt.redis_client_split_by_host` (PHPRedis) - Framework root-span overrides (Laravel, LaravelQueue, Drupal, Laminas, Lumen, Slim, SymfonyMessenger, Roadrunner, Ratchet web mode, CakePHP) use the new `Integration::tagFrameworkServiceSource` helper: cleared when user-set DD_SERVICE drove the value, else tagged with the integration name. - `m` — manual API override at serialization-time fallback in `ddtrace_serialize_span_to_rust_span` when the span's service differs from the root's and no other tag was set. Inheritance per RFC: `ddtrace_inherit_span_properties` copies `_dd.svc_src` from parent meta at span creation; no back-propagation. Tests: - 3 new `.phpt` covering default-cleared, manual `'m'`, and parent->child inheritance. - Existing `.phpt` expectations updated where manual service overrides now correctly emit `_dd.svc_src = 'm'`. Out of scope (follow-up): - Predis SPLIT_BY_HOST: stores service via meta override (`service.name`) rather than `$span->service`. Different mechanism; worth a separate discussion. Refs RFC "Service Override Source Attribution".
Leiyks
changed the title
|
Mirrors the existing pattern for _dd.p.dm / _dd.p.ksr / _dd.p.tid / runtime-id / _dd.code_origin.*: when not explicitly asserted, drop _dd.svc_src from the strict "extra tags" check so per-integration test suites don't need every test updated. Fixes 14 Memcache (and similar) integration-test failures on CI.
This reverts commit 89d443e.
…lock For each `Tag::COMPONENT => '<name>'` entry across the PHPUnit integration suite, inject `'_dd.svc_src' => '<same value>'` so the RFC contract is verified explicitly per test (instead of being filtered out at the SpanChecker level). Mechanical, 576 sites across 94 test files. Catches drift between the integration's NAME constant and what shows up on spans. (Reverts the SpanChecker filter from 89d443e; this is the proper-per-test enforcement the senior asked for.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the RFC "Service Override Source Attribution" for the PHP tracer.
Every span whose service was actively chosen (vs. the tracer's default) now carries a
_dd.svc_srcmeta tag identifying the source. Cleared for the default case (DD_SERVICE-set or auto-resolved).Sources emitted (per RFC categories)
<integration_name>Integration::handleInternalSpanServiceName(auto-covers Curl, Guzzle, PDO, Mysqli, SQLSRV, MongoDB, Memcached, AMQP, Kafka, …)opt.http_client_split_by_domainopt.db_client_split_by_instanceopt.redis_client_split_by_host<integration_name>(only whenDD_SERVICEis not user-set)Integration::tagFrameworkServiceSourcehelpermddtrace_serialize_span_to_rust_spanwhen span's service differs from root's and no other source tag was setDD_SERVICEor auto)