libdatadog update to a1da9fc3#3944
Open
dd-octo-sts[bot] wants to merge 1 commit into
Open
Conversation
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/116689495 Full CI result: ❌ 27 job(s) failed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated update of the libdatadog submodule to the latest HEAD.
a84923e5ec124efb59e413adac98afb9546a490ba1da9fc35a6e46fb0cbe016da3f56df3c1b583d1Full CI result: ❌ 27 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/116689495
libdatadog Integration Report
libdatadog SHA: a1da9fc35a6e46fb0cbe016da3f56df3c1b583d1
Analysis date: 2026-06-03
Overall status
✅ Clean update
No API incompatibilities were found. The dd-trace-php Rust/C sources compile and
link against libdatadog
a1da9fcwithout modification. The 27 failing jobs are allruntime/infrastructure failures (Windows job timeouts and the externally-maintained
System Tests suite), not compilation or API-surface breakage. No code changes were made.
Build & test summary
The new libdatadog only carries two commits since the pinned SHA:
a1da9fc35feat: cross-language LTO to inline C TLS shim into Rust FFI (Fix system ini handling of invalid values in zai config #1982)43a5c6b87feat(data-pipeline): move the async boundary up (feat(ci) accelerates Rust builds and tests by using the build cache #2064)Neither produced a compile error in our tree.
Sub-pipeline outcomes (from
bridges.json):shared-triggerprofiler-triggerappsec-triggertracer-triggerwindows test_c [7.2]and[7.3]failed — both timeoutspackage-triggerSystem Tests(verify stage) failed — 25 jobsFailure-reason breakdown across all 27 persistent failures (
all_failures.json):job_execution_timeout—windows test_c: [7.2],windows test_c: [7.3]script_failure—System Tests: [..., tracer-release]across every PHPversion (7.0–8.5) and SAPI (php-fpm, apache-mod, zts variants), all in the
verifystage.Crucially:
traces/artifact directory is empty — the harness captures trace tails onlyfor compilation/build failures, and there were none.
build-stage failures anywhere. The two failing stages aretest(the Windows C-test timeout) and
verify(System Tests). A real libdatadog API change(renamed symbol, changed signature, new required field, etc.) would surface as a Rust/C
build failure in the tracer/appsec/profiler/shared builds — none occurred.
(
shared,profiler,appsec) all passed, including their export paths.I verified that every
data-pipeline/trace_exporterdefinition touched by thechangelog lives under
libdatadog/(the C-ABI surface inlibdd-data-pipeline-ffi);dd-trace-php's own consumers of that ABI compiled cleanly, so the "move the async
boundary up" change preserved the FFI signatures we depend on.
Non-trivial changes made
No code changes required.
Identified libdatadog issues
None identified.
The data-pipeline change (#2064, "move the async boundary up") is an internal threading
refactor of trace submission. It did not break our build and the FFI consumers passed,
so there is nothing to work around. It is noted here only as the single behavioral change
in this update; if a future investigation links a System Tests regression to trace
flushing timing, this commit would be the first place to look — but the current evidence
does not support attributing the System Tests failures to it (see below).
Flaky / ignored failures
windows test_c: [7.2]and[7.3]—job_execution_timeout. Both ran for ~3601sand hit the 1-hour job cap rather than failing a compile or assertion. This is a Windows
runner timeout (infrastructure/flaky), unrelated to the libdatadog API. Ignored.
25 ×
System Tests: [..., tracer-release]—script_failure(verify stage). Theserun the separately-maintained DataDog system-tests harness against a fully built
tracer-releasepackage on a scheduledmasterpipeline. The package build itselfsucceeded (failures are in
verify, notbuild), and the failures are uniform acrossall PHP versions and SAPIs, which is characteristic of a system-tests-harness/environment
issue rather than version-specific tracer breakage. No system-test logs were downloaded
into the artifacts (only job metadata), and there is no compilation impact, so these
cannot be attributed to a libdatadog API change and require no code adaptation. Treated
as unrelated/flaky. If they persist, they warrant a separate human look at the
system-tests logs, independent of this libdatadog bump.
/cc @bwoebi