Split system-test docker image creation to work in both protected and unprotected environments - #9094
Conversation
BenchmarksBenchmark execution time: 2026-08-21 14:16:41 Comparing candidate commit 03e1eae in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
Summary of changes
Update system-test docker image creation to work both on master and on PRs
Reason for change
#8865 moves our secrets into protected environments, which means they can no longer be accessed from PRs. Unfortunately, the docker-image artifact creation can be enabled on PRs by adding the
docker_image_artifactslabel, so that PR breaks that workflow. This PR re-enables it, with the caveat that it is subject to stricter rate limits (which shouldn't be an issue in practice, given this is rarely used, and the only workflow that needs this approach)Implementation details
Test coverage
This is the test 🤞As this depends on new workflows, I don't think we can test it till after it's merged, so :yolo:
Other details