Try to make it so that CODEOWNERs triggers tests - #9092
Conversation
Tests rely on CODEOWNERS so if we change it we should atlease run normal integration tests.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9092) and master. ✅ No regressions detected |
BenchmarksBenchmark execution time: 2026-08-20 21:15:53 Comparing candidate commit dff7e24 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 67 known flaky benchmarks, 59 flaky benchmarks without significant changes.
|
andrewlock
left a comment
There was a problem hiding this comment.
Kind of annoying though, isn't it 😅
| - .azure-pipelines/noop-pipeline.yml | ||
| - .gitignore | ||
| - .github/ | ||
| # CODEOWNERS is intentionally not excluded because it is consumed by tracer tests. |
There was a problem hiding this comment.
AFAICT, we should be able to do something like this? 🤔
pr:
paths:
include:
- '**'
- .github/CODEOWNERS
exclude:
- .github
...There was a problem hiding this comment.
We may need to update the code that parses this yaml though too, just FYI 😅 We parse it in Nuke IIRC to decide what to do in the noop pipeline for example
Summary of changes
Tests rely on CODEOWNERS so if we change it we should at least run normal integration tests.
Reason for change
I broke tests in #9084 as they didn't run
Implementation details
Just went through and expanded
.github/Granted that does mean that new files we add there (for some reason) will need to be added, but all that happens is CI will just run if that is forgotten so I think that is a reasonable tradeoff.
Test coverage
😃
Other details