[Agentless] Introduce global agentless configuration key - #9059
[Agentless] Introduce global agentless configuration key#9059dudikeleti wants to merge 1 commit into
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9059) and master.
|
|||||||||||||||||||||||||||||||||||
| Metric | Master (Mean ± 95% CI) | Current (Mean ± 95% CI) | Change | Status |
|---|---|---|---|---|
| .NET Framework 4.8 - Baseline | ||||
| duration | 190.35 ± (190.91 - 191.69) ms | 214.63 ± (214.17 - 215.09) ms | +12.8% | ❌⬆️ |
| .NET Framework 4.8 - Bailout | ||||
| duration | 194.19 ± (194.09 - 194.56) ms | 217.94 ± (217.80 - 218.63) ms | +12.2% | ❌⬆️ |
| .NET Framework 4.8 - CallTarget+Inlining+NGEN | ||||
| duration | 1151.33 ± (1150.44 - 1155.97) ms | 1269.26 ± (1269.57 - 1276.80) ms | +10.2% | ❌⬆️ |
BenchmarksBenchmark execution time: 2026-08-15 15:56:36 Comparing candidate commit a40340d in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 65 known flaky benchmarks, 61 flaky benchmarks without significant changes.
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new global configuration key to enable “agentless” (direct-to-intake) behavior for supported products, with generated constants updated across target frameworks.
Changes:
- Added
DD_AGENTLESS_ENABLEDto the supported configuration catalog. - Generated a new
ConfigurationKeys.AgentlessEnabledconstant for all supported TFMs. - Documented precedence/behavior and default value (disabled).
Reviewed changes
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tracer/src/Datadog.Trace/Generated/netstandard2.0/Datadog.Trace.SourceGenerators/ConfigurationKeysGenerator/ConfigurationKeys.g.cs | Adds generated constant and XML docs for DD_AGENTLESS_ENABLED. |
| tracer/src/Datadog.Trace/Generated/netcoreapp3.1/Datadog.Trace.SourceGenerators/ConfigurationKeysGenerator/ConfigurationKeys.g.cs | Adds generated constant and XML docs for DD_AGENTLESS_ENABLED. |
| tracer/src/Datadog.Trace/Generated/net6.0/Datadog.Trace.SourceGenerators/ConfigurationKeysGenerator/ConfigurationKeys.g.cs | Adds generated constant and XML docs for DD_AGENTLESS_ENABLED. |
| tracer/src/Datadog.Trace/Generated/net461/Datadog.Trace.SourceGenerators/ConfigurationKeysGenerator/ConfigurationKeys.g.cs | Adds generated constant and XML docs for DD_AGENTLESS_ENABLED. |
| tracer/src/Datadog.Trace/Configuration/supported-configurations.yaml | Registers DD_AGENTLESS_ENABLED with type/default and documentation for codegen and docs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Configuration key to disable polling the /info endpoint in the trace agent for feature discovery. | ||
| Default value is true (polling enabled). | ||
| <seealso cref="TracerSettings.AgentFeaturePollingEnabled"/> | ||
| DD_AGENTLESS_ENABLED: |
There was a problem hiding this comment.
This is a Very general switch? 🤔 What products support this? I should think that we should want to get buy-in across all products even if they don't support agentless yet before introducing a switch like this 🤔
e.g. does this also impact CI Visibility? Does it do things like disable remote config (not available) and the discovery service? How will it interact with Feature flag agentless behaviours etc 😅
There was a problem hiding this comment.
Yes, there are a lot here 😅 This PR currently doesn't impact anything, so I didn't add an explanation, but I probably should have.
Eventually, we want a single switch for everything, with support for overrides, as well as Remote Config. We’ll discuss it.
For reference:
DataDog/libdatadog#2112
DataDog/dd-trace-py#19487
DataDog/dd-trace-py#19631
There was a problem hiding this comment.
Yes, DD_AGENTLESS_ENABLED should support everything, but profiling (and the special FFE way of fetching via fastly) - for now.
I do however recommend to not provide a global agentless switch, until agentless RC is available. I.e. the experience is completely seamless across all languages, affecting all products equally.
Otherwise e.g. appsec won't work properly, neither DI etc.
Summary of changes
DD_AGENTLESS_ENABLEDas a configuration key.ConfigurationKeys.AgentlessEnabledfor all supported TFMs.Reason for change
Implementation details