[ACTP] serve PAR signing keys from the Core Agent

[embeaken]

Summary

• maintain an authoritative AP_RUNNER_KEYS snapshot in the Core Agent
• expose the snapshot through authenticated AgentSecure.GetPARSigningKeys
• propagate Remote Config initialization and expiration status without a local TTL
• validate snapshots atomically and distinguish empty, uninitialized, expired, and unavailable states

Stack

Depends on #54590. This PR is the new base for #54591 and the remaining par-control stack.

Validation

• bazel test //pkg/config/remote/client:client_test //comp/remote-config/rcclient/impl:impl_test //comp/privateactionrunner/signingkeys/impl:impl_test //comp/api/grpcserver/impl-agent:impl-agent_test
• targeted dda inv linter.go for PAR signing-key packages

[dd-octo-sts]

Go Package Import Differences

Baseline: 296059f
Comparison: b7654e3

binary	os	arch	change
agent	linux	amd64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
agent	linux	arm64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
agent	windows	amd64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
agent	darwin	amd64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
agent	darwin	arm64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
agent	aix	ppc64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
iot-agent	linux	amd64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
iot-agent	linux	arm64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
heroku-agent	linux	amd64	+9, -0 +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/def +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/fx +github.com/DataDog/datadog-agent/comp/privateactionrunner/signingkeys/impl +github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/connection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/libs/privateconnection +github.com/DataDog/datadog-agent/pkg/privateactionrunner/signingkeys +github.com/DataDog/datadog-agent/pkg/privateactionrunner/types +github.com/DataDog/datadog-agent/pkg/proto/pbgo/privateactionrunner/privateactions
privateactionrunner	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunner	linux	arm64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunner	windows	amd64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunner	darwin	amd64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunner	darwin	arm64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity

[datadog-datadog-prod-us1]

🎯 Code Coverage (details)
• Patch Coverage: 48.85%
• Overall Coverage: 52.65% (+0.04%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b7654e3 | Docs | View more details | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 296059ff:

Results for datadog-agent_7.84.0~devel.git.450.b7654e3.pipeline.132944425-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.450.b7654e3.pipeline.132944425-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor 296059f
📊 Static Quality Gates Dashboard
🔗 SQG Job

Error

	Quality gate	Change	Size (prev → curr → max)
❌	agent_rpm_arm64 (on disk)	+157.44 KiB (0.02% increase, -600.90% of buffer)	737.104 → 737.258 → 737.130
❌	agent_suse_arm64 (on disk)	+157.44 KiB (0.02% increase, -600.90% of buffer)	737.104 → 737.258 → 737.130

Gate failure full details

Quality gate	Error type	Error message
agent_rpm_arm64	AbsoluteLimitExceeded	static_quality_gate_agent_rpm_arm64 failed! Disk size 737.3 MB exceeds limit of 737.1 MB by 131.2 KB
agent_suse_arm64	AbsoluteLimitExceeded	static_quality_gate_agent_suse_arm64 failed! Disk size 737.3 MB exceeds limit of 737.1 MB by 131.2 KB

Static quality gate failures prevent this PR from merging!
You can check the static quality gates runbooks page for guidance and tools. Please either fix the size violation or request an exception.

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+161.41 KiB (0.02% increase, -4.61% of buffer)	761.181 → 761.338 → 764.600
✅	agent_deb_amd64_fips	+133.22 KiB (0.02% increase, -6.82% of buffer)	713.931 → 714.061 → 715.840
✅	agent_heroku_amd64	+80.75 KiB (0.03% increase, -1.28% of buffer)	312.896 → 312.974 → 319.080
✅	agent_msi	+199.0 KiB (0.03% increase, -1.47% of buffer)	647.835 → 648.029 → 661.050
✅	agent_rpm_amd64	+161.41 KiB (0.02% increase, -4.63% of buffer)	761.165 → 761.322 → 764.570
✅	agent_rpm_amd64_fips	+133.22 KiB (0.02% increase, -6.76% of buffer)	713.915 → 714.045 → 715.840
✅	agent_rpm_arm64_fips	+133.19 KiB (0.02% increase, -18.97% of buffer)	693.134 → 693.264 → 693.820
✅	agent_suse_amd64	+161.41 KiB (0.02% increase, -4.63% of buffer)	761.165 → 761.322 → 764.570
✅	agent_suse_amd64_fips	+133.22 KiB (0.02% increase, -6.76% of buffer)	713.915 → 714.045 → 715.840
✅	agent_suse_arm64_fips	+133.19 KiB (0.02% increase, -18.97% of buffer)	693.134 → 693.264 → 693.820
✅	docker_agent_amd64	+153.34 KiB (0.02% increase, -39.46% of buffer)	819.760 → 819.910 → 820.140
✅	docker_agent_arm64	+157.37 KiB (0.02% increase, -86.38% of buffer)	820.712 → 820.866 → 820.890
✅	docker_agent_jmx_amd64	+153.35 KiB (0.01% increase, -61.88% of buffer)	1010.658 → 1010.808 → 1010.900
✅	docker_agent_jmx_arm64	+157.37 KiB (0.02% increase, -49.91% of buffer)	1000.262 → 1000.416 → 1000.570
✅	docker_cluster_agent_amd64	+12.15 KiB (0.01% increase, -1.68% of buffer)	211.422 → 211.434 → 212.130
✅	docker_cluster_agent_arm64	+64.16 KiB (0.03% increase, -8.22% of buffer)	224.458 → 224.520 → 225.220
✅	docker_dogstatsd_amd64	+8.06 KiB (0.02% increase, -0.86% of buffer)	39.522 → 39.530 → 40.440
✅	docker_host_profiler_amd64	+20.62 KiB (0.01% increase, -0.19% of buffer)	306.843 → 306.863 → 317.700
✅	docker_host_profiler_arm64	+3.06 KiB (0.00% increase, -0.03% of buffer)	318.121 → 318.123 → 328.970
✅	dogstatsd_deb_amd64	+4.06 KiB (0.01% increase, -0.42% of buffer)	30.267 → 30.271 → 31.210
✅	dogstatsd_deb_arm64	+4.06 KiB (0.01% increase, -0.31% of buffer)	28.294 → 28.298 → 29.590
✅	dogstatsd_rpm_amd64	+4.06 KiB (0.01% increase, -0.42% of buffer)	30.267 → 30.271 → 31.210
✅	dogstatsd_suse_amd64	+4.06 KiB (0.01% increase, -0.42% of buffer)	30.267 → 30.271 → 31.210
✅	iot_agent_deb_amd64	+72.66 KiB (0.15% increase, -7.12% of buffer)	46.553 → 46.624 → 47.550
✅	iot_agent_deb_arm64	+72.62 KiB (0.16% increase, -6.99% of buffer)	43.206 → 43.277 → 44.220
✅	iot_agent_deb_armhf	+76.4 KiB (0.17% increase, -7.32% of buffer)	44.000 → 44.075 → 45.020
✅	iot_agent_rpm_amd64	+72.66 KiB (0.15% increase, -7.12% of buffer)	46.554 → 46.625 → 47.550
✅	iot_agent_suse_amd64	+72.66 KiB (0.15% increase, -7.12% of buffer)	46.553 → 46.624 → 47.550

3 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	docker_cws_instrumentation_amd64	7.443 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_arm64	37.623 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 6238b58f-1668-4dce-87a7-10ea1c86a020

Baseline: c45db9e
Comparison: b7654e3
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.19	[+1.31, +3.07]	1	Logs bounds checks dashboard
➖	dsd_uds_10mb_3k_timestamped_contexts_memory	memory utilization	+0.85	[+0.63, +1.06]	1	Logs
➖	quality_gate_idle	memory utilization	+0.26	[+0.22, +0.30]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.13	[+0.09, +0.17]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.12	[+0.08, +0.16]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	-0.06	[-0.18, +0.06]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.17	[-0.23, -0.12]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.28	[-0.52, -0.05]	1	Logs bounds checks dashboard
➖	dsd_uds_10mb_3k_timestamped_contexts_cpu	% cpu utilization	-0.42	[-0.66, -0.18]	1	Logs
➖	quality_gate_security_no_fs_load	memory utilization	-0.60	[-0.69, -0.52]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	172.96MiB ≤ 178MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	747.27KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	531.76MiB ≤ 538MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.14MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	19 ≤ 40	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	213.66MiB ≤ 229MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.23MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	368.98 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	19 ≤ 40	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	420.10MiB ≤ 453MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	71.73MiB ≤ 76MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	42.51 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	325.95MiB ≤ 335MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	61.77 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	305.48MiB ≤ 314MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	27.74 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	313.20MiB ≤ 343MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.