♻️ migrate all packages to individual createHook instances#4749
Draft
BenoitZugmeyer wants to merge 2 commits into
Draft
♻️ migrate all packages to individual createHook instances#4749BenoitZugmeyer wants to merge 2 commits into
BenoitZugmeyer wants to merge 2 commits into
Conversation
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 2c93329 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The hooks system previously used a centralized object with a
HookNamesenum to register and trigger callbacks. This made each consumer depend on the full hooks object even when it only needed one specific hook, and provided no per-hook type safety. Moving to individual, typedHookinstances makes each component receive exactly the hook it needs, with proper TypeScript types for its parameters and return value.This is a first step toward moving hooks and their dependencies to
js-core, which will be done in a follow-up PR.Changes
createHook<Params, Result>()primitive tobrowser-corewith a typedHook<Params, Result>interface (register/trigger), preservingDISCARDEDandSKIPPEDsemanticsabstractHooks-basedHookstype inbrowser-rum-corewith a plain object of namedHookinstances (assemble,assembleTelemetry)accountContext,globalContext,tabContext,urlContexts,viewCollection,trackingConsentContext) to accept individual hook instances instead of the full hooks objectTest instructions
This is a pure internal refactoring — no user-visible behaviour changes. Load any standard RUM or Logs sandbox setup and verify that events continue to be collected normally.
Checklist