✅ Simplify debugger API spec call sites#4741
Draft
watson wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 7, 2026
Bundles Sizes Evolution
|
|
9c9b8ac to
f32c7a4
Compare
756a1f9 to
b25f283
Compare
ae7762d to
9b05c9e
Compare
b25f283 to
e8fc165
Compare
9b05c9e to
f6260d9
Compare
e8fc165 to
e5f2a0a
Compare
f6260d9 to
b4c641f
Compare
e5f2a0a to
656b091
Compare
b4c641f to
eb2aef1
Compare
656b091 to
ce161a8
Compare
eb2aef1 to
f4a6786
Compare
b84e461 to
8ee7eb9
Compare
f4a6786 to
753205e
Compare
e8a449e to
42ea55b
Compare
Use a named `thisArg` fixture where tests pass a placeholder `this` value. Also rely on default parameters for omitted `args` and `locals` so call sites highlight only the values relevant to each expectation.
42ea55b to
4ded1f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
The debugger API specs often passed
{}for placeholderthis,args, orlocalsvalues. Those call sites were harder to read because it was not obvious which empty object represented which parameter.Changes
thisArgtest fixture for placeholderthisvalues.onEntry,onReturn, andonThrowalready provide default values.Test instructions
yarn test:unit --spec packages/browser-debugger/src/domain/api.spec.tsChecklist