✨ Add Browser RUM Salesforce support by BeltranBulbarellaDD · Pull Request #4726 · DataDog/browser-sdk

BeltranBulbarellaDD · 2026-06-04T09:27:39Z

Motivation

Make the SDK not crash when instrumenting in Salesforce lightning environments.

Changes

Adds the support on the SDK so it not crashes on LWC environment.

The main idea of this is to use isEventSupported to patch the 3 listeners LWC does not support. By using isEventSupported we can try to assign the listener and it fails safely.
We do this check on 3 things: change event of CookieStore, unhandledrejection event and securitypolicyviolation event listener

The other 2 changes is to safely access globalObject.location instead of just location per Salesforce docs.

Also adds unit tests.

Test instructions

Don't forget to make in the Dev Extension: Event collection strategy to Requests

Lightning application URL
Username: 1780401668150_test-avrjsf381uzm@example.com
Password: Ufv7@chnbkeqmdssfjfn

Experience Cloud URL

Checklist

Tested locally
Tested on staging
Added unit tests for this change.
Added e2e/integration tests for this change.
Updated documentation and/or relevant AGENTS.md file

datadog-official · 2026-06-04T09:28:51Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 73.68%
• Overall Coverage: 76.70% (-0.08%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: ecbb855 | Docs | Datadog PR Page | Give us feedback!}

cit-pr-commenter-54b7da · 2026-06-04T09:29:02Z

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	171.78 KiB	172.08 KiB	+316 B	+0.18%	✅
Rum Profiler	7.88 KiB	7.88 KiB	+2 B	+0.02%	✅
Rum Recorder	21.21 KiB	21.22 KiB	+7 B	+0.03%	✅
Logs	54.30 KiB	54.50 KiB	+211 B	+0.38%	✅
Rum Slim	129.68 KiB	129.91 KiB	+233 B	+0.18%	✅
Worker	22.96 KiB	22.96 KiB	0 B	0.00%	✅

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c6cd15706

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BenoitZugmeyer · 2026-06-04T14:50:29Z

+  // Salesforce LWS does not support the unhandledrejection event. https://developer.salesforce.com/tools/lws-distortion-viewer
+  if (!isEventSupported(globalObject.window, DOM_EVENT.UNHANDLED_REJECTION, noop)) {
+    return { stop: noop }
+  }


thought: I understand that we want to test for cookieStore "change" event explicitly, because else the session manager won't work correctly.

However, for other events, I wonder if it wouldn't be simpler to wrap the addEventListener in a try/catch and ignore event silently.

I think this way just makes it clearer we are trying to attach the event in Salesforce. If we were to wrap the addEventListener we might catch/fail on other things without realizing it?

BenoitZugmeyer · 2026-06-04T14:53:10Z


 export function instrumentUnhandledRejection(callback: UnhandledErrorCallback) {
+  // Salesforce LWS does not support the unhandledrejection event. https://developer.salesforce.com/tools/lws-distortion-viewer
+  if (!isEventSupported(globalObject.window, DOM_EVENT.UNHANDLED_REJECTION, noop)) {


nitpick: globalObject.window is a bit redundant

Suggested change

if (!isEventSupported(globalObject.window, DOM_EVENT.UNHANDLED_REJECTION, noop)) {

if (!isEventSupported(window, DOM_EVENT.UNHANDLED_REJECTION, noop)) {

Actually it breaks compatibility. Do you think there is another way?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48f1282cc2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mormubis · 2026-06-08T15:13:01Z

@@ -17,7 +25,7 @@ export function createLocationChangeObservable(configuration: RumConfiguration)
      if (currentLocation.href === location.href) {


Should we replace this location.href with getLocation().href too?

BeltranBulbarellaDD changed the title ~~Beltran.bulbarella/browser rum salesforce package~~ ✨ Add Browser RUM Salesforce package and support Jun 4, 2026

BeltranBulbarellaDD force-pushed the beltran.bulbarella/browser-rum-salesforce-package branch from f4cc6bb to 5ce95a1 Compare June 4, 2026 09:43

This was referenced Jun 4, 2026

✨ Add initial Salesforce support. #4676

Closed

feat: add Salesforce POC with view tracking and e2e tests #4518

Closed

BeltranBulbarellaDD force-pushed the beltran.bulbarella/browser-rum-salesforce-package branch 2 times, most recently from 3260f6c to 288b9de Compare June 4, 2026 10:52

BeltranBulbarellaDD added 2 commits June 4, 2026 13:47

Add new Browser-rum-salesforce package

5dadb50

Add support for Salesforce LWS

8c6cd15

BeltranBulbarellaDD force-pushed the beltran.bulbarella/browser-rum-salesforce-package branch from 288b9de to 8c6cd15 Compare June 4, 2026 11:48

BeltranBulbarellaDD marked this pull request as ready for review June 4, 2026 12:11

BeltranBulbarellaDD requested a review from a team as a code owner June 4, 2026 12:11

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread packages/browser-rum-salesforce/src/entries/main.ts Outdated

Comment thread packages/browser-rum-salesforce/package.json Outdated

Comment thread packages/browser-rum-core/src/domain/contexts/urlContexts.ts

BenoitZugmeyer reviewed Jun 4, 2026

View reviewed changes

Address comments from review

48f1282

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread packages/browser-core/src/browser/cookieAccess.ts Outdated

Comment thread packages/browser-rum-slim/src/salesforce/README.md Outdated

Comment thread packages/browser-rum-slim/src/salesforce/README.md

Comment thread packages/browser-rum-slim/src/salesforce/README.md

BeltranBulbarellaDD force-pushed the beltran.bulbarella/browser-rum-salesforce-package branch from d6d99ef to a076a34 Compare June 4, 2026 16:14

Address comments from Codex

0fe7170

BeltranBulbarellaDD force-pushed the beltran.bulbarella/browser-rum-salesforce-package branch 3 times, most recently from 3627b68 to 6a3c328 Compare June 8, 2026 10:43

BeltranBulbarellaDD marked this pull request as draft June 8, 2026 10:44

BeltranBulbarellaDD force-pushed the beltran.bulbarella/browser-rum-salesforce-package branch 2 times, most recently from dc41ce2 to 7f0783d Compare June 8, 2026 11:25

Add unit tests

ecbb855

BeltranBulbarellaDD force-pushed the beltran.bulbarella/browser-rum-salesforce-package branch from 7f0783d to ecbb855 Compare June 8, 2026 11:28

BeltranBulbarellaDD changed the title ~~✨ Add Browser RUM Salesforce package and support~~ ✨ Add Browser RUM Salesforce support Jun 8, 2026

BeltranBulbarellaDD marked this pull request as ready for review June 8, 2026 11:46

mormubis reviewed Jun 8, 2026

View reviewed changes

	if (!isEventSupported(globalObject.window, DOM_EVENT.UNHANDLED_REJECTION, noop)) {
	if (!isEventSupported(window, DOM_EVENT.UNHANDLED_REJECTION, noop)) {

		@@ -17,7 +25,7 @@ export function createLocationChangeObservable(configuration: RumConfiguration)
		if (currentLocation.href === location.href) {

Conversation

BeltranBulbarellaDD commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Test instructions

Checklist

Uh oh!

datadog-official Bot commented Jun 4, 2026 • edited by datadog-prod-us1-3 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cit-pr-commenter-54b7da Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundles Sizes Evolution

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenoitZugmeyer Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

BeltranBulbarellaDD Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenoitZugmeyer Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

BeltranBulbarellaDD Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mormubis Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BeltranBulbarellaDD commented Jun 4, 2026 •

edited

Loading

datadog-official Bot commented Jun 4, 2026 •

edited by datadog-prod-us1-3 Bot

Loading

cit-pr-commenter-54b7da Bot commented Jun 4, 2026 •

edited

Loading

BeltranBulbarellaDD Jun 4, 2026 •

edited

Loading