fix(session): orphan running sessions reaper + interrupt finish (#1251)#1254
Merged
Conversation
Reap only with WHERE status='running' so a concurrent completed finish cannot be overwritten as interrupted (#1251 / Bugbot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interrupted(engineKeyboardInterrupt→finish_session; SIGTERM→KeyboardInterrupt on scan CLI;finish_sessionrefuses to overwrite non-running).pid+owner_hostnameon open; migrate viaALTER;reap_orphaned_running_sessions()at DB init reaps dead/NULL PIDs only — never a live PID.Test plan
./scripts/check-all.sh --enforced(green)os.getpid()skipped; legacy DB withoutpidmigrates + reapsinterrupted+finished_atsetCloses #1251
Made with Cursor