fix(integrity): honest build_digest_matched (#1211)#1247
Merged
Conversation
…verclaim Rename and retighten the integrity-anchor digest flag so unset DATA_BOAR_EXPECTED_BUILD_DIGEST no longer claims verification, with legacy SQLite column migration and fail-closed tests. Closes #1211
After RENAME COLUMN, reset the old default-true overclaim to 0 so existing anchors do not keep claiming digest match under the new name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signature_ok→build_digest_matchedand record True only whenDATA_BOAR_EXPECTED_BUILD_DIGESTwas set and matched (digest compare, not crypto signature).signature_ok→build_digest_matchedso old DBs do not stay perpetualunknown.Closes #1211
Test plan
./scripts/quick-test.sh --path tests/test_integrity_anchor.py./scripts/check-all.sh --enforcedMade with Cursor