Support multi-language role and acknowledgments.text in institutions data - #55
Merged
Conversation
…acknowledgment retrieval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
institutions.json(source of truth in DashAI'sdocs/static/institutions/institutions.json) changedroleandacknowledgments.textfrom plain strings to per-language objects (en,es,pt,de,zh). This updates the website's types and consumers to resolve the correct locale at render time, with a fallback to English for any locale not present in the data.Changes by file
lib/institutions.tsSupportedLang('en' | 'es' | 'pt' | 'de' | 'zh') andLocalizedTexttypes.Institution.roleandacknowledgments.textnow typed asLocalizedTextinstead ofstring.resolveLocalized()helper (resolves by locale, falls back to `egetInstitutionRole(institution, lang)to resolve an institution's localized role.getAcknowledgmentsText()now accepts any locale string and uses the same fallback logic.components/community/InstitutionsGrid.tsxinst.roleto a string viagetInstitutionRole(inst, lang)using the currenti18n.language, before merging with funder logos (unchanged, already resolved viat(...)).components/community/routes/AboutRoute.tsxes/pt/enternary for language selection; now passesi18n.languagedirectly togetAcknowledgmentsText, since fallback handling lives centrally inlib/institutions.ts.lib/institutions-data.jsoninstitutions.jsowledgments.textnow as per-language objects (en,es,pt,de,zh).Test
Manually check
/homeand/aboutines,en,pt,de,zhto confirm institution roles and acknowledgments text render correctly per locale.