This repository was archived by the owner on Jun 25, 2026. It is now read-only.
Override brace-expansion to patched versions to resolve DoS advisory#91
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Three transitive copies of brace-expansion were vulnerable to the zero-step-sequence DoS (GHSA-f886-m6hf-6m8v) and numeric-range max bypass (GHSA-jxxr-4gwj-5jf2): eslint -> minimatch@10 -> brace-expansion@5.0.5 jest-circus -> ... -> minimatch@9 -> brace-expansion@2.0.2 ts-jest -> ... -> test-exclude -> minimatch@3 -> brace-expansion@1.1.12 The advisory spans three major ranges, so version-targeted npm overrides bump each to its respective patched release (1.1.15 / 2.1.1 / 5.0.6) without forcing a single major across incompatible consumers. Build and all 37 tests pass on node 24.
fastjames
force-pushed
the
deps/brace-expansion-advisory
branch
from
June 24, 2026 16:31
a1bdf1a to
ee8e4ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the
brace-expansionadvisories (GHSA-f886-m6hf-6m8v zero-step-sequence DoS, GHSA-jxxr-4gwj-5jf2 numeric-range max bypass).Problem
Three transitive copies of
brace-expansion, in three different major ranges, were vulnerable:Fix
Because the advisory spans majors 1.x / 2.x / 5.x, a single override can't fix all three without forcing one major onto incompatible
minimatchconsumers. Instead, version-targetedoverridesbump each range to its own patched release:Result:
1.1.12 -> 1.1.15,2.0.2 -> 2.1.1,5.0.5 -> 5.0.6. Lockfile-only beyond the overrides block.Verification (node v24.14.0, per
engines: >= 24)npm run build(tsc) — passesnpm test— 37 passed, 4 suitesnpm audit— brace-expansion advisory no longer presentNote
The remaining advisories are tracked separately:
@babel/corein #89 and thejs-yamlistanbul chain in #90.