Skip to content

Add golangci-lint and coverage reporting to CI - #19

Merged
Darkroom4364 merged 5 commits into
mainfrom
fix/ci-lint
Apr 17, 2026
Merged

Add golangci-lint and coverage reporting to CI#19
Darkroom4364 merged 5 commits into
mainfrom
fix/ci-lint

Conversation

@Darkroom4364

@Darkroom4364 Darkroom4364 commented Apr 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add golangci-lint job and coverage reporting to CI workflow
  • Fix UDP DNS queries ignoring configured timeout (use dns.Client instead of dns.Exchange)

Test plan

  • CI lint job passes
  • Coverage report appears in test job output
  • UDP DNS queries respect --timeout flag

@Darkroom4364 Darkroom4364 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — Request Changes

CI additions (lint job, coverage reporting) are correct and useful.

Issues:

  • ~15 unrelated code changes bundled with the CI change (NO_COLOR, UTF-8 validation, error surfacing, batch refactor, skip counting, timeout validation, etc.). Split into CI-only vs. code/logic PRs.
  • DoH timeout is plumbed through but the UDP dns.Exchange path still ignores it — should use a dns.Client with timeout set for consistency.
  • Corruption threshold: when len(corrupted) <= 6, no byte gets flipped — silent false negative. Worth a guard or comment.

@Darkroom4364 Darkroom4364 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failing

@Darkroom4364
Darkroom4364 merged commit 2c6d044 into main Apr 17, 2026
4 checks passed
@Darkroom4364
Darkroom4364 deleted the fix/ci-lint branch April 17, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant