Fix silent error swallowing and stale test comment - #16
Merged
Conversation
- Validate UTF-8 in public_name and trailing bytes in cipher suites - Enforce TLS 1.3 for ECH negotiation, smarter retry corruption - Respect --timeout for DoH, validate timeout/flag conflicts - Return exit code from runBatch instead of calling os.Exit - Support NO_COLOR, exclude skipped checks from total count - Add 9 new unit tests for parsing, output, and edge cases
Previously, CheckRetryConfigs silently discarded the parse error when retry_configs failed to parse and the retry connection error when the retry TLS handshake failed. Both are now stored in RetryResult fields and reported in the CLI output. Closes #9
output.go handles NO_COLOR in init(). The comment was stale. Closes #12
Darkroom4364
commented
Apr 17, 2026
Darkroom4364
left a comment
Darkroom4364
left a comment
Owner
Author
There was a problem hiding this comment.
Review — Request Changes
Code itself is correct and well-tested — surfacing ParseError/RetryError, UTF-8 validation, NO_COLOR support, skip counting fix are all good changes.
Issues:
- ~7 distinct behavioral changes bundled into one PR (error surfacing, UTF-8 validation, NO_COLOR, skip counting, batch refactor, timeout validation, TLS 1.3 warning). This violates "one concern per commit" — split into focused PRs or at minimum separate commits.
- DoH timeout is plumbed through but the UDP
dns.Exchangepath still ignoresDNSOptions.Timeout— inconsistent behavior depending on transport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckRetryConfigsinstead of silently discarding them (Silent error swallowing in CheckRetryConfigs #9)output_test.goclaiming NO_COLOR is unimplemented (Incorrect comment in output_test.go claims NO_COLOR is not implemented #12)Test plan
go buildandgo testpassCloses #9, closes #12