Skip to content

Docker Stack Select Dial#20

Merged
Darkdragon14 merged 5 commits into
Darkdragon14:mainfrom
AiAeForks:add-stack-dial-button
Jun 4, 2026
Merged

Docker Stack Select Dial#20
Darkdragon14 merged 5 commits into
Darkdragon14:mainfrom
AiAeForks:add-stack-dial-button

Conversation

@AiAe
Copy link
Copy Markdown
Contributor

@AiAe AiAe commented Jun 3, 2026

CleanShot 2026-06-03 at 5  55 29 CleanShot 2026-06-03 at 5  55 44

Comment thread src/actions/docker-stack-select-start.ts Outdated
Comment thread src/actions/docker-stack-select-start.ts Outdated
Comment thread src/actions/docker-stack-select-start.ts Outdated
@AiAe
Copy link
Copy Markdown
Contributor Author

AiAe commented Jun 3, 2026

@Darkdragon14 should be good to go now.

@Darkdragon14
Copy link
Copy Markdown
Owner

Small non-blocking point: since the action now toggles the stack instead of only starting it, maybe it would be clearer to rename the internal action/file for consistency.

For example:

  • DockerStackSelectStartDockerStackSelectToggle
  • docker-stack-select-startdocker-stack-select-toggle

If you’re motivated to update it, that would be nice. Otherwise, no worries, we can keep it as-is for this PR.

@AiAe
Copy link
Copy Markdown
Contributor Author

AiAe commented Jun 3, 2026

Small non-blocking point: since the action now toggles the stack instead of only starting it, maybe it would be clearer to rename the internal action/file for consistency.

For example:

* `DockerStackSelectStart` → `DockerStackSelectToggle`

* `docker-stack-select-start` → `docker-stack-select-toggle`

If you’re motivated to update it, that would be nice. Otherwise, no worries, we can keep it as-is for this PR.

Was gonna do that but also got lazy but yeah :D
Did that + removed the new unused function left from when it had to check if stack is started.

@AiAe AiAe marked this pull request as draft June 3, 2026 20:30
@AiAe AiAe marked this pull request as ready for review June 3, 2026 20:31
@AiAe AiAe requested a review from Darkdragon14 June 3, 2026 20:31
@Darkdragon14
Copy link
Copy Markdown
Owner

I approved the PR 👍

I’ll merge it tonight so I can prepare the release properly, both on GitHub and on the Elgato Marketplace.

Big thanks again for your contribution!

@Darkdragon14 Darkdragon14 merged commit b60fc66 into Darkdragon14:main Jun 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Blank stack button that will assign it to running stacks.

2 participants