moves smartphone contact sorting to the ui/client-side - #1281
Open
Absolucy wants to merge 2 commits into
Open
Conversation
Contributor
|
have you tested this with someone changing their published name? does it correctly remove the old entry and update the new one? if you can confirm that bug doesnt exist, lgtm |
Contributor
Author
|
yep. i actually did ensure it worked when unpublishing/republishing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
nukes the
sort_listcalls from/obj/item/smartphone/ui_data, moving them to client-side sorts in the actual tgui.testing proof:
Why It's Good For The Game
less server-side lag
Changelog
🆑
fix: made smartphone contacts lag the server less
/:cl: