Fixes masquerade breaching clan spawns - #1255
Conversation
TheCarnalest
left a comment
TheCarnalest
left a comment
There was a problem hiding this comment.
As with the comment, I think it'd be better to remove COMSIG_MOB_LOGIN and merge apply_after_setup() into on_join_round() with the better signal
| @@ -61,14 +62,19 @@ | |||
| */ | |||
There was a problem hiding this comment.
This comment needs to be edited to explain the separation between on_join_round() and apply_after_setup() better, also the "teleport Masquerade-breaching Clans to safe areas" thing is in apply_after_setup() now
There was a problem hiding this comment.
Actually is there even a point to having a proc that gets called before character setup finishes? I think it might be more sane to merge apply_after_setup() into on_join_round() and have it run off COMSIG_HUMAN_CHARACTER_SETUP_FINISHED instead
There was a problem hiding this comment.
On join round catches stuff like normal outfit equip or deathmatch
COMSIG_HUMAN_CHARACTER_SETUP_FINISHED is for specificly acctually joining or late joining the round.
3 participants
About The Pull Request
Nossie wont get ripped out of deathmatches and other spawns.
I can also set my own loadout items and if they protect you, your shit wont get replaced.
Why It's Good For The Game
Fixes #848
Fixes The-Final-Nights/The-Final-Nights-Rebase#388
Changelog
🆑
fix: Masquerade breaches no longer get smuggled out of deathmatch arena and other spawns not meant to send them to the sewers
fix: Loadout items wont get replaced by robes and masks assuming they cover your breaches
/:cl: