Sequence web sdks#407
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Code Review
This pull request upgrades the Web SDK to version 6.0.6, migrating to Wagmi v3 and Viem v2.45 while introducing the useSendWalletTransaction and useHasPermission hooks. The update includes a comprehensive UI refactor across the checkout, connect, and wallet-widget packages using the latest design system, alongside branding updates and the removal of the immutable-connector and Sardine integrations. Feedback highlights a critical security risk in the README.md example regarding wildcard postMessage usage and a regression in SocialLink where secure randomness was replaced with Math.random(). Additionally, a bug was identified in the block explorer URL construction, and the string replacement logic for calldata in credit card payments was found to be fragile and incomplete.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Ticket link:
API breaking changes:
Manual testing required:
Docs changes required:
Description