Skip to content

Sequence web sdks#407

Open
Dargon789 wants to merge 6 commits into
masterfrom
Sequence-Web-SDKs
Open

Sequence web sdks#407
Dargon789 wants to merge 6 commits into
masterfrom
Sequence-Web-SDKs

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

Ticket link:

API breaking changes:

  • Yes
  • No

Manual testing required:

  • Yes
  • No

Docs changes required:

  • Yes
  • No

Description

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 25, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel

This comment was marked as resolved.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 25, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scan Engine Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Web SDK to version 6.0.6, migrating to Wagmi v3 and Viem v2.45 while introducing the useSendWalletTransaction and useHasPermission hooks. The update includes a comprehensive UI refactor across the checkout, connect, and wallet-widget packages using the latest design system, alongside branding updates and the removal of the immutable-connector and Sardine integrations. Feedback highlights a critical security risk in the README.md example regarding wildcard postMessage usage and a regression in SocialLink where secure randomness was replaced with Math.random(). Additionally, a bug was identified in the block explorer URL construction, and the string replacement logic for calldata in credit card payments was found to be fragile and incomplete.

Comment thread README.md
Comment thread packages/checkout/src/views/TransactionStatus/index.tsx Outdated
Comment thread packages/connect/src/components/SocialLink/SocialLink.tsx
Comment thread packages/checkout/src/hooks/useCheckoutUI/useCreditCardPayment.tsx
Comment thread packages/checkout/src/views/PendingCreditCardTransaction.tsx
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
kit-embedded-wallet-nextjs-boilerplate Ready Ready Preview, Comment May 25, 2026 2:50am
kit-next-xe81 Ready Ready Preview, Comment May 25, 2026 2:50am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants