Skip to content

Update google.yml#92

Merged
Dargon789 merged 1 commit into
masterfrom
Dargon789-patch-1
Oct 13, 2025
Merged

Update google.yml#92
Dargon789 merged 1 commit into
masterfrom
Dargon789-patch-1

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

@Dargon789 Dargon789 commented Oct 13, 2025

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Summary by Sourcery

Update google.yml CI workflow to trigger on master branch and normalize quoting style

CI:

  • Switch workflow trigger from "main" to "master"
  • Use double quotes consistently for keys, values, and names in the workflow

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
next Ready Ready Preview Comment Oct 13, 2025 8:02am
react Ready Ready Preview Comment Oct 13, 2025 8:02am

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Oct 13, 2025

Reviewer's Guide

The PR modifies the Google Cloud GitHub Actions workflow by switching the branch filter from 'main' to 'master' and enforcing consistent double-quote styling for workflow names, step definitions, environment variables, and action parameters.

File-Level Changes

Change Details Files
Updated branch trigger to 'master'
  • Changed on.push.branches filter from 'main' to 'master'
.github/workflows/google.yml
Standardized quoting to double quotes
  • Replaced single quotes with double quotes in workflow and job names
  • Updated uses directives and step names to double-quoted strings
  • Converted env values and with parameters to double-quoted strings
.github/workflows/google.yml
YAML formatting consistency tweaks
  • Adjusted spacing, blank lines, and indentation for readability
.github/workflows/google.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Oct 13, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/workflows/google.yml:38` </location>
<code_context>
 on:
   push:
     branches:
       - '"master"'
+
 env:
</code_context>

<issue_to_address>
**issue (bug_risk):** Branch name is wrapped in extra quotes, which may prevent workflow triggering.

GitHub expects the branch name without extra quotes. Please update to master to ensure the workflow triggers correctly.
</issue_to_address>

### Comment 2
<location> `.github/workflows/google.yml:112` </location>
<code_context>
+      - name: "Deploy to GKE"
         run: |-
           # replacing the image name in the k8s template
           ./kustomize edit set image LOCATION-docker.pkg.dev/PROJECT_ID/REPOSITORY/IMAGE:TAG=$GAR_LOCATION-docker.pkg.dev/$PROJECT_ID/$REPOSITORY/$IMAGE:$GITHUB_SHA
           ./kustomize build . | kubectl apply -f -
           kubectl rollout status deployment/$DEPLOYMENT_NAME
</code_context>

<issue_to_address>
**issue (bug_risk):** Hardcoded placeholders in kustomize edit command may not be replaced as intended.

Only the value after '=' is interpolated; placeholders in the image name may remain unresolved. Please verify that all placeholders are replaced to avoid invalid image references.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit 3d5e2bc into master Oct 13, 2025
25 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch October 13, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant