Create ci_cargo.yml #59
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| version: 2.1 | ||
|
|
||
| jobs: | ||
| build-and-test: | ||
| docker: | ||
| - image: cimg/rust:1.88.0 | ||
| steps: | ||
| - checkout | ||
| - restore_cache: | ||
| keys: | ||
| - v1-cargo-{{ checksum "Cargo.lock" }} | ||
| - v1-cargo- | ||
| - run: | ||
| name: "Check formatting" | ||
| command: cargo fmt -- --check | ||
| - run: | ||
| name: "Run tests" | ||
| command: cargo test | ||
| - save_cache: | ||
| key: v1-cargo-{{ checksum "Cargo.lock" }} | ||
| paths: | ||
| - "~/.cargo/bin" | ||
| - "~/.cargo/registry/index" | ||
| - "~/.cargo/registry/cache" | ||
| - "~/.cargo/git/db" | ||
| - "target" | ||
| - run: | ||
| name: "Check formatting" | ||
| command: cargo fmt -- --check | ||
| - run: | ||
| name: "Run tests" | ||
| command: cargo test | ||
|
Comment on lines
+27
to
+32
There was a problem hiding this comment. These steps for checking formatting and running tests are duplicates of the steps on lines 13-18. This is redundant and makes the CI job take longer than necessary. These duplicated steps should be removed. |
||
|
|
||
| workflows: | ||
| ci: | ||
| jobs: | ||
| - build-and-test | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rust version in the Docker image (
1.88.0) does not match therust-versionspecified inCargo.toml(1.86). To ensure consistency between the development environment and CI, it's recommended to use the same Rust version.