Master (#534)#540
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| console_sol, | ||
| ) | ||
| raw_sigs = [s.strip().strip('"') for s in sig_strings] | ||
| sigs = [ | ||
| s.replace("string", "string memory").replace("bytes)", "bytes memory)") | ||
| re.sub(r"(\w+\[\])", r"\1 memory", s) |
| } | ||
|
|
||
| /** | ||
| * Determine which archive variant exists for the given artifact prefix. |
|
Deployment failed with the following error: Learn More: https://vercel.com/dargon789-forge?upgradeToPro=build-rate-limit |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Dargon789
force-pushed
the
dev-(#52-fcfa587)
branch
from
46b4eec to
4ef4980
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a significant modernization of the Foundry codebase, upgrading to Rust edition 2024 and version 1.89 while introducing a new benchmarking suite and a sample project. The changes also include a major refactor of Anvil's block execution and the addition of Tempo network support. Feedback identifies critical syntax errors in the new CircleCI configurations due to duplicate keys and redundant execution steps. Furthermore, the JSON-RPC handler requires adjustment to correctly return a single error response for empty batch calls as mandated by the specification.
I am having trouble creating individual review comments. Click here to see my feedback.
.circleci/dev_stage.yml (23-32)
This YAML file appears to have syntax errors. There are duplicate top-level keys:
jobsis defined on line 9 and again on line 23.workflowsis defined on line 18 and again on line 32.
Please merge the contents under a single jobs key and a single workflows key to fix the parsing error.
crates/anvil/server/src/handler.rs (51-55)
According to the JSON-RPC 2.0 specification, if a batch call is an empty array, the server should respond with a single Response object containing an error, not a batch response. This implementation incorrectly returns a Response::Batch. It should return a single error response to be compliant.
if calls.is_empty() {
return Some(Response::error(RpcError::invalid_request()));
}.circleci/cargo.yml (27-32)
These run steps for checking formatting and running tests are duplicates of the steps on lines 13-18. This is inefficient and likely an error. Please remove these duplicated steps.
.circleci/ci-web3-gamefi.yml (15-26)
This CI configuration appears to be a placeholder and has a few issues:
- The job name
web3-defi-game-project-on line 15 has a trailing hyphen, which is unconventional and likely a typo. - The workflow name
my-custom-workflowon line 24 is very generic. It would be better to use a more descriptive name. - The
runstep within the job is commented out, meaning the job only performs a checkout and does no actual work.
Please consider updating this to be a functional CI job or removing it if it's not yet ready.
.circleci/ci.yml (26-31)
These run steps for checking formatting and running tests are duplicates of the steps on lines 12-17. This is inefficient and likely an error. Please remove these duplicated steps.
.circleci/ci_cargo.yml (27-32)
These run steps for checking formatting and running tests are duplicates of the steps on lines 13-18. This is inefficient and likely an error. Please remove these duplicated steps.
.circleci/web3_defi_gamefi.yml (15-26)
This CI configuration appears to be a placeholder and has a few issues:
- The job name
web3-defi-game-project-on line 15 has a trailing hyphen, which is unconventional and likely a typo. - The workflow name
my-custom-workflowon line 24 is very generic. It would be better to use a more descriptive name. - The
runstep within the job is commented out, meaning the job only performs a checkout and does no actual work.
Please consider updating this to be a functional CI job or removing it if it's not yet ready.
2 participants
chore: bump forge-std version used for tests
fix(anvil-server): distinguish empty and notification batches (fix(anvil-server): distinguish empty and notification batches foundry-rs/foundry#14405)
feat(anvil): add debug_traceBlockByHash and debug_traceBlockByNumber (feat(anvil): add debug_traceBlockByHash and debug_traceBlockByNumber foundry-rs/foundry#14391)
feat(anvil): add
debug_traceBlockByHashanddebug_traceBlockByNumberRPC endpointsImplement the two missing geth debug_ block tracing endpoints that trace all transactions in a block at once, returning per-tx results.
chore(foundryup): remove tempo fork support (chore(foundryup): remove tempo fork support foundry-rs/foundry#14324)
chore: remove tempo fork support
Tempo is now fully upstream in the main Foundry repo, so the separate network handling is no longer needed.
Update Foundryup version
warn when foundryup --network is ignored
Update foundryup/foundryup
Update foundryup/foundryup
fix(lint): add missing visit methods to LateLintVisitor (fix(lint): add missing visit methods to LateLintVisitor foundry-rs/foundry#14276)
fix(lint): add missing visit methods to LateLintVisitor
fix(lint): dispatch deprecated nested late lint hooks
fix(lint): use by-value nested late lint hooks
test(lint): cover late visitor hooks
network: tempofrom Tempo template (fix: removenetwork: tempofrom Tempo template foundry-rs/foundry#14424)remove network: tempo from template
feat(anvil): RPC methods for tempo's
TipFeeManagerinanvil_*namespace (feat(anvil): RPC methods for tempo'sTipFeeManagerinanvil_*namespace foundry-rs/foundry#14414)feat(anvil): RPC methods for tempo's
TipFeeManagerinanvil_*namespacefeat(anvil): add tests + mint TIP20 tokens to admin before adding FeeAMM liquidity
fix(anvil): separate queued txs in txpool RPC responses (fix(anvil): separate queued txs in txpool RPC responses foundry-rs/foundry#14425)
refactor(cli): unify
NetworkVariantwithNetworkConfigs(refactor(cli): unifyNetworkVariantwithNetworkConfigsfoundry-rs/foundry#14426)refactor(cli): unify
NetworkVariantwithNetworkConfigschore: clean-ups + tests
fix: after fig's review
fix: skip serialization if
networkisNonechore: pin to foundry-wallets release (chore: pin to foundry-wallets release foundry-rs/foundry#14429)
pin to foundry-wallets release
fix(config): respect custom Etherscan URL in cast/forge commands (fix(config): respect custom Etherscan URL in cast/forge commands foundry-rs/foundry#14319)
fix(config): respect custom Etherscan URL in cast/forge commands
Amp-Thread-ID: https://ampcode.com/threads/T-019db9f9-01dd-729a-9f7a-ed150aabf130
fix lint
fix clippy
chore: update Cargo.lock
Amp-Thread-ID: https://ampcode.com/threads/T-019db9f9-01dd-729a-9f7a-ed150aabf130
Amp-Thread-ID: https://ampcode.com/threads/T-019db9f9-01dd-729a-9f7a-ed150aabf130
feat(common): add MPP WebSocket transport (feat(common): add MPP WebSocket transport foundry-rs/foundry#14404)
feat(common): add MPP WebSocket transport
docs
use alloy's wsbakcend::from_socket
use main repo
remove patches
bump rustls-webpki
fix: only use
MppWsConnectwhen MPP key is availablefix: install default rustls crypto provider
fix: clean imports
fix: MPP known host check
fix: MPP only if known endpoint && key available
fix(script): preserve exit reason in failed revert decode (fix(script): preserve exit reason in failed revert decode foundry-rs/foundry#13985)
fix(script): preserve exit reason in failed revert decode
test(script): cover exit reason output in script failures
fix(script): initialize exit_reason in ScriptResult default
fix(anvil): fix flaky test_increase_time_by_zero test (fix(anvil): fix flaky test_increase_time_by_zero test foundry-rs/foundry#14430)
Update benches/src/lib.rs
Update crates/cli/src/utils/suggestions.rs
Update crates/common/src/contracts.rs
Update crates/test-utils/src/script.rs
Main (Main #486)
fix: compare sign github passkey (fix: compare sign github passkey #132)
Create config.yml (Create config.yml #114)
chore(deps): bump github/codeql-action from 3 to 4 (chore(deps): bump github/codeql-action from 3 to 4 #113)
Bumps github/codeql-action from 3 to 4.
updated-dependencies:
Bumps DeterminateSystems/determinate-nix-action from 3.11.2 to 3.11.3.
updated-dependencies:
Bumps crate-ci/typos from 1.38.0 to 1.38.1.
updated-dependencies:
Bumps softprops/action-gh-release from 2.3.4 to 2.4.1.
updated-dependencies:
Bumps taiki-e/install-action from 2.62.21 to 2.62.28.
updated-dependencies:
Update test.yml (Update test.yml #115)
Update config.yml
Foundry/master (Foundry/master #122)
Create ci_cargo.yml (Create ci_cargo.yml #72)
Create config.yml
Update and rename config.yml to ci.yml
Rename ci_cargo.yml to ci_v1.yml
Update .circleci/ci_v1.yml
Update and rename config.yml to ci_deploy.yml (Update and rename config.yml to ci_deploy.yml #123)
Create snyk-container.yml
Update and rename ci.yml to ci-say-hello.yml
Update test.yml
Create config.ym (Create config.ym #128)
chore(deps): bump alloy-dyn-abi in the cargo group across 1 directory (chore(deps): bump alloy-dyn-abi from 1.4.0 to 1.4.1 in the cargo group across 1 directory #129)
Bumps the cargo group with 1 update in the / directory: alloy-dyn-abi.
Updates
alloy-dyn-abifrom 1.4.0 to 1.4.1updated-dependencies:
Create cargo.yml (Create cargo.yml #74) (Cargo update #130)
Fix typo in CircleCI config file name
Update .circleci/config.yml
Update .circleci/config.yml
Delete .circleci/cargo.yml (Delete .circleci/cargo.yml #181)
CI Configuration Removal: The .circleci/cargo.yml file, which defined specific CircleCI jobs for building and testing Rust code, has been completely removed from the repository.
This pull request updates the CircleCI configuration by correcting a repository URL in a comment and fixing a job name by removing a trailing hyphen. These are good fixes. However, the job name web3-defi-game-project itself appears to be a leftover from another project and is not descriptive. I've added a comment suggesting a rename to improve maintainability. For the same reason, you might also consider renaming the workflow my-custom-workflow to something more descriptive of what it does.
bug
Delete .circleci/ci_v1.yml (Delete .circleci/ci_v1.yml #321)
Delete .circleci/ci-say-hello.yml
bug
clean vercel block account api app next react
Dargon789/hardhat-project@92a3e1c
Update docker.yml
Revert "Delete .circleci/ci_deploy.yml (Delete .circleci/ci_deploy.yml #322)" (Revert "Delete .circleci/ci_deploy.yml" #358)
This reverts commit 87dd517.
Potential fix for code scanning alert no. 132: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 154: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 172: Uncontrolled data used in path expression
Update crates/evm/evm/src/executors/invariant/mod.rs
Potential fix for pull request finding 'CodeQL / Uncontrolled data used in path expression'
Potential fix for pull request finding 'CodeQL / Uncontrolled data used in path expression'
Update crates/cli/src/utils/suggestions.rs
Update crates/common/src/contracts.rs
Wagmi (e604566) (Wagmi (e604566) #413)
Update and rename ci-say-hello.yml to ci-web3-defi-gamefi.yml (Update and rename ci-say-hello.yml to ci-web3-defi-gamefi.yml #154)
Delete .circleci/ci-web3-defi-gamefi.yml (Delete .circleci/ci-web3-defi-gamefi.yml #155)
Delete .circleci/ci_deploy.yml (Delete .circleci/ci_deploy.yml #158)
Delete .circleci/cargo.yml (Delete .circleci/cargo.yml #159)
chore(deps): bump taiki-e/install-action from 2.62.31 to 2.62.33 (chore(deps): bump taiki-e/install-action from 2.62.31 to 2.62.33 #162)
Bumps taiki-e/install-action from 2.62.31 to 2.62.33.
updated-dependencies:
Bumps actions/checkout from 4 to 5.
updated-dependencies:
Merge branch 'foundry-rs:master' (Merge branch 'foundry-rs:master' #164)
Create ci_cargo.yml (Create ci_cargo.yml #72)
Create config.yml
Rename ci_cargo.yml to cargo.yml
fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)
fix(fmt): account for ternary operators when estimating size
fix(fmt): handle comments between inherited base contracts
test: layout + base inheritance
feat(forge): add bypass prevrandao (feat(forge): add bypass prevrandao foundry-rs/foundry#12125)
feat(forge): add bypass prevrandao
Update crates/evm/networks/src/lib.rs
changes after review: remove duped code
fix(fmt): filter libs when recursing (fix(fmt): filter libs when recursing foundry-rs/foundry#12119)
fix(fmt): account for ternary operators when estimating size
fix(fmt): filter libs when recursing
style: clippy
test: wipe contracts before formatting
test: explicitly test ignore
fix(fmt): break try stmts in a fn header-like fashion (fix(fmt): break try stmts in a fn header-like fashion foundry-rs/foundry#12131)
chore(deps): bump softprops/action-gh-release from 2.3.4 to 2.4.1
Bumps softprops/action-gh-release from 2.3.4 to 2.4.1.
updated-dependencies:
Bumps taiki-e/install-action from 2.62.28 to 2.62.33.
updated-dependencies:
fix(anvil): always disable nonce check (fix(anvil): always disable nonce check for
eth_calls foundry-rs/foundry#12144) (fix(anvil): always disable nonce check (foundry-rs#12144) #165)test: refactor testdata/ tests to be run in
forge test(test: refactor testdata/ tests to be run inforge testfoundry-rs/foundry#12049)test: run forge test on testdata/
chore: refactor to use common Test contract
chore: disable testGasMeteringExternal, via-ir
test: rm unused repros
fix: paths
upd
fmt
fix more tests
test: turn testNonExistingContractRevert into expectRevert
fix some more paths
legacy assertions
compile paris with paris
fix: set configs for fs tests
fix remaining paths in cheats
restrict fs permissions
fix: set runtime evm_version too
fix vyper
fix: a couple of repros
fix: we have storage layouts
fix: 3223, 3674: set sender
reorder
feat: move repros expected failures to snapshots
feat: migrate remaining repros tests
feat: rm migrated files
skip testRevertIfGetUnlinked
move expected core/ failures
upd
move logs/
move all forgetest tests from it/ to cli/
fix fork test
move trace/
tmp: move fuzz/invariant out of fuzz/
move fuzz/
forge fmt
wips
fix: both vyper and paris; set src/
canon
lib log
logs
Revert "fix: set runtime evm_version too"
This reverts commit 7ca544b.
Contract-level inline config will set evm version for libraries too, which means we fail on deploying libraries that are compiled with newer evm version.
fix: set evm version where needed, per test function
test: reduce gas wastage
chore: clippy
invariant mod.rs
test: fix linking tests with new utils
redact_with
Revert "wips"
This reverts commit ee2c17a.
migrate invariant/target{,Abi}
migrate InvariantAfterInvariant.t.sol
migrate InvariantAssume.t.sol
migrate InvariantCalldataDictionary.t.sol, more test utils
migrate InvariantCustomError.t.sol
migrate InvariantExcludedSenders.t.sol
migrate InvariantFixtures.t.sol
migrate InvariantHandlerFailure.t.sol
interlude: forgot to use a new file
migrate InvariantInnerContract.t.sol
migrate InvariantPreserveState.t.sol
migrate InvariantReentrancy.t.sol
migrate InvariantRollFork.t.sol
migrate InvariantScrapeValues.t.sol
migrate InvariantSequenceNoReverts.t.sol
migrate InvariantShrinkBigSequence.t.sol
migrate InvariantShrinkFailOnRevert.t.sol
migrate InvariantShrinkWithAssert.t.sol
migrate InvariantTest1.t.sol
fix InvariantInnerContract.t.sol
update new Rlp test
com
better com
nuke tests/it
test: fix testdata paths in script tester
test: fix relative paths in test_cmd
test: redact more in issue_2851
fix: copy testdata correctly
trace addrs
manual retry logic with --retry
fix nondeterministic output
debug: fs lock error context
test: fix project root for windows
test: skip project root test if unset
normalize both
typo
Revert "typo"
This reverts commit 402bea1.
This reverts commit e5caedd.
fix
fix: locked_write_line for windows
chore: clippy
fmt
chore: speed up fuzzed_selected_targets
other way
fix nondeterministic output 2
fix: disable persistence
test: revert old via-ir
ci: tweak cache key
do not run trace test when isolate
fix(anvil): always disable nonce check (fix(anvil): always disable nonce check for
eth_calls foundry-rs/foundry#12144)deps: bump deps (deps: bump deps foundry-rs/foundry#12149)
deps: bump deps
🤖 Generated with Claude Code
Update test.yml
Update test.yml (Update test.yml #167)
Update test.yml (Update test.yml #168)
Delete .circleci/ci.yml
Update cargo.yml (Update cargo.yml #171)
CI/CD Configuration Update: The CircleCI configuration file, cargo.yml, has been updated to use a newer version of the Rust Docker image.
Rust Toolchain Version Bump: The cimg/rust Docker image version has been incremented from 1.88.0 to 1.89.0, ensuring the CI pipeline utilizes a more recent Rust toolchain.
Delete .circleci/ci_v1.yml (Delete .circleci/ci_v1.yml #173)
Update cargo.yml (Update cargo.yml #174)
chore(deps): bump taiki-e/install-action from 2.62.28 to 2.62.33 (chore(deps): bump taiki-e/install-action from 2.62.28 to 2.62.33 #175)
Bumps taiki-e/install-action from 2.62.28 to 2.62.33.
updated-dependencies:
I Configuration Removal: The .circleci/cargo.yml file, which defined CircleCI jobs for building and testing Rust projects, has been completely removed from the repository.
Delete .circleci/ci_v1.yml (Delete .circleci/ci_v1.yml #182)
Update config.yml (Update config.yml #183)
Configuration File Cleanup: Removed an unnecessary blank line in the .circleci/config.yml file, improving its formatting and readability.
Update config.yml (Update config.yml #187)
Delete .circleci/config.yml
Delete .circleci directory
Update ci_v1.yml
Update Rust Docker image version to 1.89.0
Potential fix for code scanning alert no. 76: Artifact poisoning
chore(deps): bump alloy-dyn-abi in the cargo group across 1 directory
Bumps the cargo group with 1 update in the / directory: alloy-dyn-abi.
Updates
alloy-dyn-abifrom 0.8.25 to 0.8.26updated-dependencies:
Create ci-web3-gamefi.yml
Potential fix for code scanning alert no. 74: Artifact poisoning
Potential fix for code scanning alert no. 83: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 93: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 76: Artifact poisoning
Potential fix for code scanning alert no. 94: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 80: Server-side request forgery
Potential fix for code scanning alert no. 80: Server-side request forgery
Create codeql.yml (Create codeql.yml #208)
Update ci.yml (Update ci.yml #209)
https://github.com/apps/gemini-code-assist
Code Review
This pull request updates the Rust version in the CI from 1.88.0 to 1.89.0. While this is a good maintenance step, I've identified a potential improvement for your CI configuration. The project's Cargo.toml specifies a Minimum Supported Rust Version (MSRV) of 1.86, but the CI doesn't test against it. I've added a comment suggesting the addition of an MSRV check to prevent compatibility issues.
https://github.com/apps/gemini-code-assist
Code Review
This pull request downgrades the Rust version in the CI pipeline from 1.88.0 to 1.87.0. This is inconsistent with the project's declared Minimum Supported Rust Version (MSRV) of 1.89 in Cargo.toml. My review highlights this discrepancy and suggests aligning the CI's Rust version with the MSRV to ensure the project's compatibility guarantees are properly tested.
Foundry rs maste 1f4b36a (Foundry rs maste 1f4b36a #214)
Create jekyll.yml
Create docker-image.yml
Potential fix for code scanning alert no. 58: Workflow does not contain permissions
Update .github/workflows/docker-image.yml
Update docker-image.yml
Revert "chore: fix isolate tests (chore: fix isolate tests foundry-rs/foundry#10344)"
This reverts commit 70ded2b.
Delete .github/workflows/jekyll.yml
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Streamline the Docker CI workflow by renaming the file and enhancing it with scheduled runs, Buildx multi-platform builds, metadata tagging, conditional pushes, and automated image signing with Cosign.
CI:
Rename and replace the legacy docker-image.yml workflow with docker.yml Add scheduled cron runs and triggers on pushes to master, semver tags, and PRs Configure Docker Buildx for multi-platform builds with cache Extract Docker metadata and conditionally push images to GHCR on non-PR events Install Cosign and sign published Docker images using ephemeral identity tokens
Update ci.yml
Create docker-image.yml (Create docker-image.yml #224)
CI:
Introduce docker-image.yml GitHub Actions workflow to checkout code and build Docker image on ubuntu-latest
CI:
Insert comment lines to delineate and structure sections in .circleci/config.yml for enhanced clarity
Enhancements:
Add standalone # lines in sequence.rs to serve as hidden placeholders for rustdoc examples
Update dependencies.yml (Update dependencies.yml #227)
Update dependencies.yml
Refactor the weekly dependencies workflow to inline cargo update steps, auto-generate commit messages and PR bodies with update logs, and use the create-pull-request action to open update PRs on a dedicated branch.
Enhancements:
Define environment variables for GitHub token, branch name, PR title, and PR body including cargo update logs Inline checkout, Rust toolchain setup, and cargo update command with log cleanup instead of relying on an external workflow Craft commit messages and PR bodies dynamically by capturing and formatting cargo update output Use peter-evans/create-pull-request to push Cargo.lock updates to a 'cargo-update' branch
CI:
Move permissions and GitHub token configuration into the job context Explicitly set the runner to ubuntu-latest and remove the top-level empty permissions block
CI:
Add comment to the Publish Binary step indicating it runs automatically after a successful release workflow or can be triggered manually with a run_id
Update snyk-container.yml (Update snyk-container.yml #229)
Update nextest.yml (Update nextest.yml #230)
Update const.ts (Update const.ts #231)
Code Formatting: Removed an extraneous blank line in npm/src/const.ts to improve code cleanliness and consistency.
This reverts commit 8575916.
Create deploy.yml (Create deploy.yml #240)
Create deploy.yml CI:
Add GitHub Actions workflow to build the Rust project, run tests, and build a Docker image on pushes to main/master
Update dependencies.yml
Update dependencies.yml (Update dependencies.yml #247)
Improve readability of the GitHub Actions dependencies workflow by adjusting whitespace and adding blank lines CI:
Add blank line before the workflow name declaration Insert blank line after the scheduled cron job entry
CI:
Remove extraneous blank line in .github/workflows/dependencies.yml
CI:
Remove dev branch from test workflow triggers
Update Cargo.lock (Update Cargo.lock #253)
Update Cargo.lock (Update Cargo.lock #254)
Chores:
Regenerate Cargo.lock to update dependencies
Create config.yml (Create config.yml #255)
Create config.yml
Update .circleci/config.yml
Update config.yml (Update config.yml #256)
fix: upgrade tsdown from 0.15.12 to 0.16.1
Snyk has created this PR to upgrade tsdown from 0.15.12 to 0.16.1.
See this package in npm:
tsdown
See this project in Snyk:
https://app.snyk.io/org/dargon789/project/8da85645-409e-46fa-bd46-9b58e7905fb8?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr
CI:
Introduce a Google Cloud deployment workflow that builds a Docker image, pushes it to Artifact Registry, and deploys it to a GKE cluster on pushes to the main branches.
Update flake.lock (Update flake.lock #269)
Update flake.nix (Update flake.nix #270)
Adjust Nix flake development shell configuration for better cross-platform support and simplify dependencies.
Enhancements:
Remove the dprint dependency from the Nix development shell. Add conditional AppKit framework linkage on Darwin systems in the Nix shell configuration. Drop custom hardeningDisable settings from the Nix development shell definition.
https://github.com/apps/gemini-code-assist
Code Review
This pull request updates the Nix flake configuration to improve cross-platform support and simplify dependencies. The changes include removing dprint and hardeningDisable settings, and conditionally adding the AppKit framework for Darwin systems. While most changes are beneficial, removing dprint from the development shell dependencies while its configuration file remains could cause issues for contributors. I've added a comment regarding this potential inconsistency.
Update Cargo.toml (Update Cargo.toml #271)
Update nextest.toml (Update nextest.toml #272)
Adjust test runner configuration for nextest to better handle long-running and specific tests.
Enhancements:
Introduce a dedicated test group that limits chisel-serial tests to a single thread. Increase the default slow-test timeout period to reduce premature terminations for longer-running tests. Expand the slow-timeout override filter to include both ext_integration and can_test_forge_std tests.
(https://github.com/apps/gemini-code-assist)
Code Review
This pull request updates the dprint.json configuration file. The changes correctly enable formatting for dprint.json itself by modifying the excludes list, update the JSON and Markdown dprint plugins to their latest versions, and add a final newline to the file for POSIX compliance. These are all good maintenance improvements. The changes have been reviewed and appear to be correct and beneficial. No issues were found.
Update .github/workflows/apisec-scan.yml
Update counter/README.md
Update .github/ISSUE_TEMPLATE/bug_report.md
Dependabot/cargo/cargo 38744a1864 (Dependabot/cargo/cargo 38744a1864 #282)
chore(deps): bump alloy-dyn-abi in the cargo group across 1 directory
Bumps the cargo group with 1 update in the / directory: alloy-dyn-abi.
Updates
alloy-dyn-abifrom 0.8.25 to 0.8.26updated-dependencies:
Update CircleCI configuration to use a different Rust toolchain image and rename the workflow file.
Build:
Rename the CircleCI configuration file from ci.yml to cargo.yml. Change the CircleCI Docker image to use Rust 1.78.0 instead of 1.88.0.
Replace context.clone().compiler_settings.vyper with context.compiler_settings.vyper.clone() to avoid unnecessary cloning of the entire VerificationContext. This reduces memory allocations when creating VyperInput instances.
Applied to both etherscan and sourcify verification providers.
Summary by Sourcery
Update CircleCI pipeline to use a custom Docker executor and job tailored to the project instead of the example hello-world workflow.
Enhancements:
Introduce a reusable custom executor that pulls from the stable cimg/base Docker image with Docker Hub authentication. CI:
Replace the sample say-hello job and workflow with a project-specific job and workflow wired to the new custom executor in .circleci/config.yml.
fix: use network-specific BaseFeeParams for Optimism in Anvil
Dargon789 patch 1 (Dargon789 patch 1 #285)
Update test.yml
Update test.yml (Update test.yml #167)
Delete .circleci/ci_v1.yml (Delete .circleci/ci_v1.yml #173)
Update cargo.yml (Update cargo.yml #174)
Delete .circleci/config.yml
Potential fix for code scanning alert no. 74: Artifact poisoning
Potential fix for code scanning alert no. 83: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 93: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 76: Artifact poisoning
Potential fix for code scanning alert no. 94: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 80: Server-side request forgery
Update cargo.yml (Update cargo.yml #210)
https://github.com/apps/gemini-code-assist
Code Review
This pull request downgrades the Rust version in the CI pipeline from 1.88.0 to 1.87.0. This is inconsistent with the project's declared Minimum Supported Rust Version (MSRV) of 1.89 in Cargo.toml. My review highlights this discrepancy and suggests aligning the CI's Rust version with the MSRV to ensure the project's compatibility guarantees are properly tested.
Replace context.clone().compiler_settings.vyper with context.compiler_settings.vyper.clone() to avoid unnecessary cloning of the entire VerificationContext. This reduces memory allocations when creating VyperInput instances.
Applied to both etherscan and sourcify verification providers.
merge gh-master ( merge gh-master #287)
Create config.yml (Create config.yml #236)
Create .circleci/config.yml defining a version 2.1 pipeline with a docker-based "say-hello" job, checkout and echo steps, and a workflow to orchestrate it
fix(evm): use timestamp-based blob base fee calculation (fix(evm): use timestamp-based blob base fee calculation foundry-rs/foundry#12959)
fix(evm): use timestamp-based blob base fee calculation
chore: use patch
Now BPO1 is default
bump to hardforks to 0.4.7
fmt
This reverts commit 6ff4b52.
Foundry/ethereum ux (Foundry/ethereum ux #284)
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Potential fix for code scanning alert no. 61: Workflow does not contain permissions
Potential fix for code scanning alert no. 74: Artifact poisoning
Create config.yml (Create config.yml #105)
Create cargo.yml (Create cargo.yml #106)
Delete .github/workflows/docker-image.yml
Revert "Create cargo.yml (Create cargo.yml #106)"
This reverts commit 251a2b4.
https://github.com/apps/gemini-code-assist
Code Review
This pull request introduces a CircleCI workflow to automate formatting checks and tests. My review has identified two main issues in the configuration: redundant steps that would unnecessarily increase job execution time, and a mismatch between the Rust version in the CI environment and the one specified in the project's Cargo.toml. I've provided suggestions to fix these issues for a more efficient and consistent CI process.
Gamefi defi (Gamefi defi #288)
chore: ignore RUSTSEC-2025-0137 (chore: ignore RUSTSEC-2025-0137 foundry-rs/foundry#12941)
chore(deps): weekly
cargo update(chore(deps): weeklycargo updatefoundry-rs/foundry#12940)chore(deps): weekly
cargo updateUpdating git repository
https://github.com/rust-cli/rexpectUpdating git repository
https://github.com/paradigmxyz/solar.gitSkipping git submodule
https://github.com/argotorg/solidity.gitdue to update strategy in .gitmodulesUpdating git repository
https://github.com/tempoxyz/tempoUpdating git repository
https://github.com/paradigmxyz/rethLocking 71 packages to latest compatible versions
Updating alloy-chains v0.2.23 -> v0.2.24
Updating alloy-consensus v1.1.3 -> v1.2.1
Updating alloy-consensus-any v1.1.3 -> v1.2.1
Updating alloy-contract v1.1.3 -> v1.2.1
Updating alloy-dyn-abi v1.5.1 -> v1.5.2
Updating alloy-eip5792 v1.1.3 -> v1.2.1
Updating alloy-eips v1.1.3 -> v1.2.1
Updating alloy-ens v1.1.3 -> v1.2.1
Updating alloy-genesis v1.1.3 -> v1.2.1
Updating alloy-json-abi v1.5.1 -> v1.5.2
Updating alloy-json-rpc v1.1.3 -> v1.2.1
Updating alloy-network v1.1.3 -> v1.2.1
Updating alloy-network-primitives v1.1.3 -> v1.2.1
Updating alloy-primitives v1.5.1 -> v1.5.2
Updating alloy-provider v1.1.3 -> v1.2.1
Updating alloy-pubsub v1.1.3 -> v1.2.1
Updating alloy-rpc-client v1.1.3 -> v1.2.1
Updating alloy-rpc-types v1.1.3 -> v1.2.1
Updating alloy-rpc-types-anvil v1.1.3 -> v1.2.1
Updating alloy-rpc-types-any v1.1.3 -> v1.2.1
Updating alloy-rpc-types-beacon v1.1.3 -> v1.2.1
Updating alloy-rpc-types-debug v1.1.3 -> v1.2.1
Updating alloy-rpc-types-engine v1.1.3 -> v1.2.1
Updating alloy-rpc-types-eth v1.1.3 -> v1.2.1
Updating alloy-rpc-types-trace v1.1.3 -> v1.2.1
Updating alloy-rpc-types-txpool v1.1.3 -> v1.2.1
Updating alloy-serde v1.1.3 -> v1.2.1
Updating alloy-signer v1.1.3 -> v1.2.1
Updating alloy-signer-aws v1.1.3 -> v1.2.1
Updating alloy-signer-gcp v1.1.3 -> v1.2.1
Updating alloy-signer-ledger v1.1.3 -> v1.2.1
Updating alloy-signer-local v1.1.3 -> v1.2.1
Updating alloy-signer-trezor v1.1.3 -> v1.2.1
Updating alloy-signer-turnkey v1.1.3 -> v1.2.1
Updating alloy-sol-macro v1.5.1 -> v1.5.2
Updating alloy-sol-macro-expander v1.5.1 -> v1.5.2
Updating alloy-sol-macro-input v1.5.1 -> v1.5.2
Updating alloy-sol-type-parser v1.5.1 -> v1.5.2
Updating alloy-sol-types v1.5.1 -> v1.5.2
Updating alloy-transport v1.1.3 -> v1.2.1
Updating alloy-transport-http v1.1.3 -> v1.2.1
Updating alloy-transport-ipc v1.1.3 -> v1.2.1
Updating alloy-transport-ws v1.1.3 -> v1.2.1
Updating alloy-trie v0.9.1 -> v0.9.2
Updating alloy-tx-macros v1.1.3 -> v1.2.1
Unchanged annotate-snippets v0.12.5 (available: v0.12.10)
Unchanged anstyle-svg v0.1.11 (available: v0.1.12)
Downgrading aws-smithy-runtime v1.9.6 -> v1.9.5
Updating axum-core v0.5.5 -> v0.5.6
Updating cc v1.2.50 -> v1.2.51
Updating derive_more v2.1.0 -> v2.1.1
Updating derive_more-impl v2.1.0 -> v2.1.1
Updating dtoa v1.0.10 -> v1.0.11
Updating find-msvc-tools v0.1.5 -> v0.1.6
Unchanged generic-array v0.14.7 (available: v0.14.9)
Unchanged icu_collections v2.0.0 (available: v2.1.1)
Unchanged icu_normalizer v2.0.1 (available: v2.1.1)
Unchanged icu_normalizer_data v2.0.0 (available: v2.1.1)
Unchanged icu_properties v2.0.2 (available: v2.1.2)
Unchanged icu_properties_data v2.0.1 (available: v2.1.2)
Unchanged idna_adapter v1.1.0 (available: v1.2.1)
Updating itoa v1.0.15 -> v1.0.17
Updating jiff v0.2.16 -> v0.2.17
Updating jiff-static v0.2.16 -> v0.2.17
Updating libredox v0.1.11 -> v0.1.12
Updating libz-rs-sys v0.5.4 -> v0.5.5
Unchanged matchit v0.8.4 (available: v0.8.6)
Unchanged mdbook v0.4.52 (available: v0.5.2)
Updating portable-atomic v1.12.0 -> v1.13.0
Updating proc-macro2 v1.0.103 -> v1.0.104
Unchanged protobuf v3.3.0 (available: v3.7.2)
Unchanged protobuf-support v3.3.0 (available: v3.7.2)
Unchanged rand v0.8.5 (available: v0.9.2)
Unchanged ratatui v0.29.0 (available: v0.30.0)
Updating reqwest v0.12.26 -> v0.12.28
Updating ruint v1.17.0 -> v1.17.1
Updating rustix v1.1.2 -> v1.1.3
Updating ryu v1.0.21 -> v1.0.22
Updating schemars v1.1.0 -> v1.2.0
Updating schemars_derive v1.1.0 -> v1.2.0
Updating serde_json v1.0.145 -> v1.0.148
Updating signal-hook-registry v1.4.7 -> v1.4.8
Updating syn-solidity v1.5.1 -> v1.5.2
Updating tempfile v3.23.0 -> v3.24.0
Unchanged trezor-client v0.1.4 (available: v0.1.5)
Unchanged unicode-width v0.2.0 (available: v0.2.2)
Unchanged vergen v8.3.2 (available: v9.0.6)
Updating zlib-rs v0.5.4 -> v0.5.5
Adding zmij v1.0.0
note: to see how you depend on a package, run
cargo tree --invert <dep>@<ver>touchups
touchups
flake.lock: Update
Flake lock file updates:
• Updated input 'fenix':
'github:nix-community/fenix/16642c5' (2025-12-20)
→ 'github:nix-community/fenix/3479aaf' (2025-12-27) • Updated input 'fenix/rust-analyzer-src':
'github:rust-lang/rust-analyzer/ea1d299' (2025-12-18)
→ 'github:rust-lang/rust-analyzer/8c5a68e' (2025-12-26) • Updated input 'nixpkgs':
'github:NixOS/nixpkgs/7d853e5' (2025-12-19)
→ 'github:NixOS/nixpkgs/3edc4a3' (2025-12-27)
fix(chisel): uninitalized variables (fix(chisel): uninitalized variables foundry-rs/foundry#12937)
chore(deps): bump Swatinem/rust-cache from 2.8.1 to 2.8.2 (chore(deps): bump Swatinem/rust-cache from 2.8.1 to 2.8.2 foundry-rs/foundry#12919)
Bumps Swatinem/rust-cache from 2.8.1 to 2.8.2.
updated-dependencies:
Bumps peter-evans/create-pull-request from 7.0.11 to 8.0.0.
updated-dependencies:
chore: sepolia rpc url private
Bumps crate-ci/typos from 1.40.0 to 1.40.1.
updated-dependencies:
chore(deps): bump DeterminateSystems/determinate-nix-action
Bumps DeterminateSystems/determinate-nix-action from 3.15.0 to 3.15.1.
updated-dependencies:
Bumps taiki-e/install-action from 2.65.1 to 2.65.7.
updated-dependencies:
fix(config): err on unknown profile (fix(config): err on unknown profile foundry-rs/foundry#12946)
test: remove duplicate Issue2851 test (test: remove duplicate Issue2851 test foundry-rs/foundry#12953)
chore(cheats): make sign(Wallet) pure (chore(cheats): make sign(Wallet) pure foundry-rs/foundry#12912)
chore(cheats): make sign(Wallet) pure
ignore
fix(evm): use timestamp-based blob base fee calculation (fix(evm): use timestamp-based blob base fee calculation foundry-rs/foundry#12959)
fix(evm): use timestamp-based blob base fee calculation
chore: use patch
Now BPO1 is default
bump to hardforks to 0.4.7
fmt
This reverts commit 6ff4b52.
Update mod.rs
Introduce a basic CircleCI pipeline for the web3 GameFi project, providing a custom Docker executor and a stub job within a workflow.
CI:
Add CircleCI config file ci-web3-gamefi.yml with version 2.1 pipeline Define a custom executor using the cimg/base:stable Docker image with Docker Hub credentials Create a web3-defi-game-project- job and integrate it into a my-custom-workflow
Merge pull request Circleci project setup #47 (Merge pull request #47 #290)
Add .circleci/config.yml
Updated config.yml
Updated config.yml
Updated config.yml
Update test.yml
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Signed-off-by: AU_gdev_19 <64…
Motivation
Solution
PR Checklist