Foundry/master test ux

[Dargon789]

Motivation

Solution

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
next	Canceled		May 2, 2026 6:53am

[sourcery-ai]

Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Code Review

This pull request introduces significant updates across the Foundry codebase, including extensive dependency updates, the implementation of several new lint rules such as could-be-immutable, rtlo, and missing-zero-check, the transition of documentation generation and Chisel to use the solar AST, and the addition of new RPC endpoints for block tracing and Tempo-specific state management in Anvil. It also refactors network configuration to use a canonical network field, adds a PostExec transaction type for OP stack, improves script failure reporting, and updates foundryup to fetch the latest release via the GitHub API. Feedback highlights a violation of the JSON-RPC 2.0 specification for empty batch requests, an O(N^2) performance bottleneck in the new block tracing implementation, and opportunities to refine the logic of the could-be-immutable and missing-zero-check lint rules to improve accuracy and coverage.

[gemini-code-assist]

According to the JSON-RPC 2.0 specification, an empty batch request should return a single error response object, not a batch response (array) containing an error. The spec states: "If the Batch rpc call itself fails to be recognized as an valid JSON or as an Array with at least one value, the response from the Server MUST be a single Response object."

            if calls.is_empty() {
                return Some(Response::error(RpcError::invalid_request()));
            }

[gemini-code-assist]

This implementation of debug_trace_block_by_hash (and similarly debug_trace_block_by_number) has O(N^2) complexity relative to the number of transactions in the block. This is because debug_trace_transaction re-executes all transactions in the block up to the target index. For a block with many transactions, this will be extremely slow. A more efficient approach would be to execute the entire block once and collect traces for all transactions in a single pass.

[gemini-code-assist]

Enums and user-defined value types (UDVTs) are also value types in Solidity and can be declared as immutable. The current check only considers elementary value types and contracts. Consider including Enum and Udvt in the candidate types.

Suggested change

	TypeKind::Custom(hir::ItemId::Contract(_)) => true,
	TypeKind::Custom(hir::ItemId::Contract(_) | hir::ItemId::Enum(_) | hir::ItemId::Udvt(_)) => true,

[gemini-code-assist]

The current guard detection logic is too broad and will lead to false negatives. It considers a variable "guarded" if it is read anywhere within a guard context (like an if condition), regardless of the actual check performed. For example, if (a == address(0)) { owner = a; } would incorrectly mark a as guarded because it is read in the condition, even though the branch explicitly uses the zero address. A more robust check should verify that the variable is compared against address(0) and that the sink is only reachable when the variable is non-zero.