fix update recovery project use github action ci/cd (#352)#353
fix update recovery project use github action ci/cd (#352)#353Dargon789 wants to merge 0 commit into
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
2761a5e to
cc693d3
Compare
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request consolidates a wide array of updates and new features, primarily focusing on enhancing CI/CD robustness, updating core dependencies, and expanding EVM and RPC functionalities. Key additions include support for Tempo transactions, a new cheatcode for JSON-formatted logs, and improved contract cloning capabilities with Sourcify integration. The changes also encompass substantial code refactoring and bug fixes to improve stability and developer experience. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a large amalgamation of various features, fixes, and dependency updates. My review focuses on the CI/CD configuration changes, where I've found some issues. Specifically, there are a couple of workflow files with redundant steps that will increase job execution time, and one file with an invalid structure that will cause CI to fail. I've provided suggestions to fix these issues. The other changes, including extensive dependency updates, new features like Sourcify support for forge clone and Tempo transaction support in cast, and various refactorings and bug fixes, look solid.
I am having trouble creating individual review comments. Click here to see my feedback.
.circleci/dev_stage.yml (1-70)
This CircleCI configuration file has an invalid structure. It contains multiple jobs and workflows keys at the top level, and a jobs key nested inside a workflows map (line 23). A valid CircleCI config should have a single top-level jobs map and a single top-level workflows map. This file will cause a parsing error and needs to be restructured.
.circleci/ci.yml (26-31)
The steps for checking formatting and running tests are repeated. These steps are already executed on lines 12-17 before saving the cache. Removing these redundant steps will make the CI job faster.
.circleci/ci_cargo.yml (27-32)
The steps for checking formatting and running tests are repeated. These steps are already executed on lines 13-18 before saving the cache. Removing these redundant steps will make the CI job faster.
Add .circleci/config.yml
Updated config.yml
Updated config.yml
Updated config.yml
Update test.yml
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Update test.yml (Update test.yml #46)
chore(deps): bump revm to 24.0.0 (chore(deps): bump revm to 24.0.0 foundry-rs/foundry#10601)
feat: implement add_balance endpoint (feat: implement add_balance endpoint foundry-rs/foundry#10636)
fix(bindings): ensure forge bind generates snake_case file names (fix(bindings): ensure forge bind generates snake_case file names foundry-rs/foundry#10622)
fix(bindings): ensure forge bind generates snake_case file names
refactor: use heck crate for snake_case conversion
chore: standardize lint help + validate docs existance (chore: standardize lint help + validate docs existance foundry-rs/foundry#10639)
feat(cast mktx): add support for "--ethsign" option (feat(cast mktx): add support for "--ethsign" option foundry-rs/foundry#10641)
chore(wallets): improve error message on signer instantiation failure
chore: replaced anvil hardforks with alloy hardforks (chore: replaced anvil hardforks with alloy hardforks foundry-rs/foundry#10612)
chore: replaced anvil hardforks with alloy hardforks
fixes
fixes
fixes
removed redundant op and alloy hardforks enum
fixes
fixes
bumped alloy hardforks and kept default to prague and isthmus
bumped alloy-hardforks and fixes
fix(
anvil): latest evm version should be prague (fix(anvil): latest evm version should be prague foundry-rs/foundry#10653)fix(
anvil): latest evm version should be praguefix test
nit
chore(deps): bump tracing-subscriber (chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20 in the cargo group across 1 directory #51)
Bumps the cargo group with 1 update in the / directory: tracing-subscriber.
Updates
tracing-subscriberfrom 0.3.19 to 0.3.20updated-dependencies:
Update test.yml (Update test.yml #52)
Update docker-image.yml (Update docker-image.yml #53)
Create ci_cargo.yml (Create ci_cargo.yml #59)
Create web3_defi_gamefi.yml (Create web3_defi_gamefi.yml #61)
Update dependencies.yml
Potential fix for code scanning alert no. 21: Workflow does not contain permissions
Create ci_cargo.yml (Create ci_cargo.yml #72)
Create config.yml
Update and rename config.yml to ci.yml
Rename ci_cargo.yml to ci_v1.yml
Update .circleci/ci_v1.yml
Update CircleCI config with comments and formatting
Delete .circleci/ci.yml
Update ci_v1.yml
Update Rust Docker image version to 1.89.0
Update dependencies.yml
Update dependencies.yml (Update dependencies.yml #247)
Improve readability of the GitHub Actions dependencies workflow by adjusting whitespace and adding blank lines CI:
Add blank line before the workflow name declaration Insert blank line after the scheduled cron job entry
CI:
Remove extraneous blank line in .github/workflows/dependencies.yml
CI:
Remove dev branch from test workflow triggers
Create config.yml (Create config.yml #255)
Create config.yml
Update .circleci/config.yml
Summary by Sourcery
Update CircleCI pipeline to use a custom Docker executor and job tailored to the project instead of the example hello-world workflow.
Enhancements:
Introduce a reusable custom executor that pulls from the stable cimg/base Docker image with Docker Hub authentication. CI:
Replace the sample say-hello job and workflow with a project-specific job and workflow wired to the new custom executor in .circleci/config.yml.
fix: use network-specific BaseFeeParams for Optimism in Anvil
fix(evm): use timestamp-based blob base fee calculation (fix(evm): use timestamp-based blob base fee calculation foundry-rs/foundry#12959)
fix(evm): use timestamp-based blob base fee calculation
chore: use patch
Now BPO1 is default
bump to hardforks to 0.4.7
fmt
This reverts commit 6ff4b52.
Update mod.rs
Dargon789 patch 1 (Dargon789 patch 1 #285)
Update test.yml
Update test.yml (Update test.yml #167)
Delete .circleci/ci_v1.yml (Delete .circleci/ci_v1.yml #173)
Update cargo.yml (Update cargo.yml #174)
Delete .circleci/config.yml
Potential fix for code scanning alert no. 74: Artifact poisoning
Potential fix for code scanning alert no. 83: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 93: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 76: Artifact poisoning
Potential fix for code scanning alert no. 94: Uncontrolled data used in path expression
Potential fix for code scanning alert no. 80: Server-side request forgery
Update cargo.yml (Update cargo.yml #210)
https://github.com/apps/gemini-code-assist
Code Review
This pull request downgrades the Rust version in the CI pipeline from 1.88.0 to 1.87.0. This is inconsistent with the project's declared Minimum Supported Rust Version (MSRV) of 1.89 in Cargo.toml. My review highlights this discrepancy and suggests aligning the CI's Rust version with the MSRV to ensure the project's compatibility guarantees are properly tested.
Replace context.clone().compiler_settings.vyper with context.compiler_settings.vyper.clone() to avoid unnecessary cloning of the entire VerificationContext. This reduces memory allocations when creating VyperInput instances.
Applied to both etherscan and sourcify verification providers.
merge gh-master ( merge gh-master #287)
Create config.yml (Create config.yml #236)
Create .circleci/config.yml defining a version 2.1 pipeline with a docker-based "say-hello" job, checkout and echo steps, and a workflow to orchestrate it
fix(evm): use timestamp-based blob base fee calculation (fix(evm): use timestamp-based blob base fee calculation foundry-rs/foundry#12959)
fix(evm): use timestamp-based blob base fee calculation
chore: use patch
Now BPO1 is default
bump to hardforks to 0.4.7
fmt
This reverts commit 6ff4b52.
Foundry/ethereum ux (Foundry/ethereum ux #284)
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Potential fix for code scanning alert no. 61: Workflow does not contain permissions
Potential fix for code scanning alert no. 74: Artifact poisoning
Create config.yml (Create config.yml #105)
Create cargo.yml (Create cargo.yml #106)
Delete .github/workflows/docker-image.yml
Revert "Create cargo.yml (Create cargo.yml #106)"
This reverts commit 251a2b4.
https://github.com/apps/gemini-code-assist
Code Review
This pull request introduces a CircleCI workflow to automate formatting checks and tests. My review has identified two main issues in the configuration: redundant steps that would unnecessarily increase job execution time, and a mismatch between the Rust version in the CI environment and the one specified in the project's Cargo.toml. I've provided suggestions to fix these issues for a more efficient and consistent CI process.
Gamefi defi (Gamefi defi #288)
chore: ignore RUSTSEC-2025-0137 (chore: ignore RUSTSEC-2025-0137 foundry-rs/foundry#12941)
chore(deps): weekly
cargo update(chore(deps): weeklycargo updatefoundry-rs/foundry#12940)chore(deps): weekly
cargo updateUpdating git repository
https://github.com/rust-cli/rexpectUpdating git repository
https://github.com/paradigmxyz/solar.gitSkipping git submodule
https://github.com/argotorg/solidity.gitdue to update strategy in .gitmodulesUpdating git repository
https://github.com/tempoxyz/tempoUpdating git repository
https://github.com/paradigmxyz/rethLocking 71 packages to latest compatible versions
Updating alloy-chains v0.2.23 -> v0.2.24
Updating alloy-consensus v1.1.3 -> v1.2.1
Updating alloy-consensus-any v1.1.3 -> v1.2.1
Updating alloy-contract v1.1.3 -> v1.2.1
Updating alloy-dyn-abi v1.5.1 -> v1.5.2
Updating alloy-eip5792 v1.1.3 -> v1.2.1
Updating alloy-eips v1.1.3 -> v1.2.1
Updating alloy-ens v1.1.3 -> v1.2.1
Updating alloy-genesis v1.1.3 -> v1.2.1
Updating alloy-json-abi v1.5.1 -> v1.5.2
Updating alloy-json-rpc v1.1.3 -> v1.2.1
Updating alloy-network v1.1.3 -> v1.2.1
Updating alloy-network-primitives v1.1.3 -> v1.2.1
Updating alloy-primitives v1.5.1 -> v1.5.2
Updating alloy-provider v1.1.3 -> v1.2.1
Updating alloy-pubsub v1.1.3 -> v1.2.1
Updating alloy-rpc-client v1.1.3 -> v1.2.1
Updating alloy-rpc-types v1.1.3 -> v1.2.1
Updating alloy-rpc-types-anvil v1.1.3 -> v1.2.1
Updating alloy-rpc-types-any v1.1.3 -> v1.2.1
Updating alloy-rpc-types-beacon v1.1.3 -> v1.2.1
Updating alloy-rpc-types-debug v1.1.3 -> v1.2.1
Updating alloy-rpc-types-engine v1.1.3 -> v1.2.1
Updating alloy-rpc-types-eth v1.1.3 -> v1.2.1
Updating alloy-rpc-types-trace v1.1.3 -> v1.2.1
Updating alloy-rpc-types-txpool v1.1.3 -> v1.2.1
Updating alloy-serde v1.1.3 -> v1.2.1
Updating alloy-signer v1.1.3 -> v1.2.1
Updating alloy-signer-aws v1.1.3 -> v1.2.1
Updating alloy-signer-gcp v1.1.3 -> v1.2.1
Updating alloy-signer-ledger v1.1.3 -> v1.2.1
Updating alloy-signer-local v1.1.3 -> v1.2.1
Updating alloy-signer-trezor v1.1.3 -> v1.2.1
Updating alloy-signer-turnkey v1.1.3 -> v1.2.1
Updating alloy-sol-macro v1.5.1 -> v1.5.2
Updating alloy-sol-macro-expander v1.5.1 -> v1.5.2
Updating alloy-sol-macro-input v1.5.1 -> v1.5.2
Updating alloy-sol-type-parser v1.5.1 -> v1.5.2
Updating alloy-sol-types v1.5.1 -> v1.5.2
Updating alloy-transport v1.1.3 -> v1.2.1
Updating alloy-transport-http v1.1.3 -> v1.2.1
Updating alloy-transport-ipc v1.1.3 -> v1.2.1
Updating alloy-transport-ws v1.1.3 -> v1.2.1
Updating alloy-trie v0.9.1 -> v0.9.2
Updating alloy-tx-macros v1.1.3 -> v1.2.1
Unchanged annotate-snippets v0.12.5 (available: v0.12.10)
Unchanged anstyle-svg v0.1.11 (available: v0.1.12)
Downgrading aws-smithy-runtime v1.9.6 -> v1.9.5
Updating axum-core v0.5.5 -> v0.5.6
Updating cc v1.2.50 -> v1.2.51
Updating derive_more v2.1.0 -> v2.1.1
Updating derive_more-impl v2.1.0 -> v2.1.1
Updating dtoa v1.0.10 -> v1.0.11
Updating find-msvc-tools v0.1.5 -> v0.1.6
Unchanged generic-array v0.14.7 (available: v0.14.9)
Unchanged icu_collections v2.0.0 (available: v2.1.1)
Unchanged icu_normalizer v2.0.1 (available: v2.1.1)
Unchanged icu_normalizer_data v2.0.0 (available: v2.1.1)
Unchanged icu_properties v2.0.2 (available: v2.1.2)
Unchanged icu_properties_data v2.0.1 (available: v2.1.2)
Unchanged idna_adapter v1.1.0 (available: v1.2.1)
Updating itoa v1.0.15 -> v1.0.17
Updating jiff v0.2.16 -> v0.2.17
Updating jiff-static v0.2.16 -> v0.2.17
Updating libredox v0.1.11 -> v0.1.12
Updating libz-rs-sys v0.5.4 -> v0.5.5
Unchanged matchit v0.8.4 (available: v0.8.6)
Unchanged mdbook v0.4.52 (available: v0.5.2)
Updating portable-atomic v1.12.0 -> v1.13.0
Updating proc-macro2 v1.0.103 -> v1.0.104
Unchanged protobuf v3.3.0 (available: v3.7.2)
Unchanged protobuf-support v3.3.0 (available: v3.7.2)
Unchanged rand v0.8.5 (available: v0.9.2)
Unchanged ratatui v0.29.0 (available: v0.30.0)
Updating reqwest v0.12.26 -> v0.12.28
Updating ruint v1.17.0 -> v1.17.1
Updating rustix v1.1.2 -> v1.1.3
Updating ryu v1.0.21 -> v1.0.22
Updating schemars v1.1.0 -> v1.2.0
Updating schemars_derive v1.1.0 -> v1.2.0
Updating serde_json v1.0.145 -> v1.0.148
Updating signal-hook-registry v1.4.7 -> v1.4.8
Updating syn-solidity v1.5.1 -> v1.5.2
Updating tempfile v3.23.0 -> v3.24.0
Unchanged trezor-client v0.1.4 (available: v0.1.5)
Unchanged unicode-width v0.2.0 (available: v0.2.2)
Unchanged vergen v8.3.2 (available: v9.0.6)
Updating zlib-rs v0.5.4 -> v0.5.5
Adding zmij v1.0.0
note: to see how you depend on a package, run
cargo tree --invert <dep>@<ver>touchups
touchups
flake.lock: Update
Flake lock file updates:
• Updated input 'fenix':
'github:nix-community/fenix/16642c5' (2025-12-20)
→ 'github:nix-community/fenix/3479aaf' (2025-12-27) • Updated input 'fenix/rust-analyzer-src':
'github:rust-lang/rust-analyzer/ea1d299' (2025-12-18)
→ 'github:rust-lang/rust-analyzer/8c5a68e' (2025-12-26) • Updated input 'nixpkgs':
'github:NixOS/nixpkgs/7d853e5' (2025-12-19)
→ 'github:NixOS/nixpkgs/3edc4a3' (2025-12-27)
fix(chisel): uninitalized variables (fix(chisel): uninitalized variables foundry-rs/foundry#12937)
chore(deps): bump Swatinem/rust-cache from 2.8.1 to 2.8.2 (chore(deps): bump Swatinem/rust-cache from 2.8.1 to 2.8.2 foundry-rs/foundry#12919)
Bumps Swatinem/rust-cache from 2.8.1 to 2.8.2.
updated-dependencies:
Bumps peter-evans/create-pull-request from 7.0.11 to 8.0.0.
updated-dependencies:
chore: sepolia rpc url private
Bumps crate-ci/typos from 1.40.0 to 1.40.1.
updated-dependencies:
chore(deps): bump DeterminateSystems/determinate-nix-action
Bumps DeterminateSystems/determinate-nix-action from 3.15.0 to 3.15.1.
updated-dependencies:
Bumps taiki-e/install-action from 2.65.1 to 2.65.7.
updated-dependencies:
fix(config): err on unknown profile (fix(config): err on unknown profile foundry-rs/foundry#12946)
test: remove duplicate Issue2851 test (test: remove duplicate Issue2851 test foundry-rs/foundry#12953)
chore(cheats): make sign(Wallet) pure (chore(cheats): make sign(Wallet) pure foundry-rs/foundry#12912)
chore(cheats): make sign(Wallet) pure
ignore
fix(evm): use timestamp-based blob base fee calculation (fix(evm): use timestamp-based blob base fee calculation foundry-rs/foundry#12959)
fix(evm): use timestamp-based blob base fee calculation
chore: use patch
Now BPO1 is default
bump to hardforks to 0.4.7
fmt
This reverts commit 6ff4b52.
Update mod.rs
Introduce a basic CircleCI pipeline for the web3 GameFi project, providing a custom Docker executor and a stub job within a workflow.
CI:
Add CircleCI config file ci-web3-gamefi.yml with version 2.1 pipeline Define a custom executor using the cimg/base:stable Docker image with Docker Hub credentials Create a web3-defi-game-project- job and integrate it into a my-custom-workflow
Merge pull request Circleci project setup #47 (Merge pull request #47 #290)
Add .circleci/config.yml
Updated config.yml
Updated config.yml
Updated config.yml
Update test.yml
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Update test.yml (Update test.yml #46)
chore(deps): bump revm to 24.0.0 (chore(deps): bump revm to 24.0.0 foundry-rs/foundry#10601)
feat: implement add_balance endpoint (feat: implement add_balance endpoint foundry-rs/foundry#10636)
fix(bindings): ensure forge bind generates snake_case file names (fix(bindings): ensure forge bind generates snake_case file names foundry-rs/foundry#10622)
fix(bindings): ensure forge bind generates snake_case file names
refactor: use heck crate for snake_case conversion
chore: standardize lint help + validate docs existance (chore: standardize lint help + validate docs existance foundry-rs/foundry#10639)
feat(cast mktx): add support for "--ethsign" option (feat(cast mktx): add support for "--ethsign" option foundry-rs/foundry#10641)
chore(wallets): improve error message on signer instantiation failure
chore: replaced anvil hardforks with alloy hardforks (chore: replaced anvil hardforks with alloy hardforks foundry-rs/foundry#10612)
chore: replaced anvil hardforks with alloy hardforks
fixes
fixes
fixes
removed redundant op and alloy hardforks enum
fixes
fixes
bumped alloy hardforks and kept default to prague and isthmus
bumped alloy-hardforks and fixes
fix(
anvil): latest evm version should be prague (fix(anvil): latest evm version should be prague foundry-rs/foundry#10653)fix(
anvil): latest evm version should be praguefix test
nit
chore(deps): bump tracing-subscriber (chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20 in the cargo group across 1 directory #51)
Bumps the cargo group with 1 update in the / directory: tracing-subscriber.
Updates
tracing-subscriberfrom 0.3.19 to 0.3.20updated-dependencies:
Update test.yml (Update test.yml #52)
Update docker-image.yml (Update docker-image.yml #53)
Create ci_cargo.yml (Create ci_cargo.yml #59)
Create web3_defi_gamefi.yml (Create web3_defi_gamefi.yml #61)
Update dependencies.yml
Potential fix for code scanning alert no. 21: Workflow does not contain permissions
Update dependencies.yml
Update dependencies.yml (Update dependencies.yml #247)
Improve readability of the GitHub Actions dependencies workflow by adjusting whitespace and adding blank lines CI:
Add blank line before the workflow name declaration Insert blank line after the scheduled cron job entry
CI:
Remove extraneous blank line in .github/workflows/dependencies.yml
CI:
Remove dev branch from test workflow triggers
Update crates/evm/evm/src/executors/corpus.rs
Foundry/master test ux (Foundry/master test ux #295)
Update ci.yml
Update ci.yml (Update ci.yml #211)
This pull request updates the Rust version in the CircleCI workflow to 1.89.0. This is a good maintenance task to keep the CI environment up-to-date. I have one suggestion regarding the Docker image tag to potentially simplify future maintenance by automatically adopting patch releases. Overall, the change is correct and beneficial.
CI:
Include the 'main' branch in the push event triggers for the test workflow
@0xrusowsky @Dargon789 fix(fmt): handle trailing coments between base contracts Revert 142 master (#296)
Create ci_cargo.yml (Create ci_cargo.yml #72)
Create config.yml
Rename ci_cargo.yml to cargo.yml
fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)
fix(fmt): account for ternary operators when estimating size
fix(fmt): handle comments between inherited base contracts
test: layout + base inheritance
Revert "fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)"
This reverts commit b8b5fbb.
CI/CD Configuration Update: The CircleCI configuration file, .circleci/cargo.yml, has been updated to use a newer version of the Rust Docker image.
Rust Toolchain Version Bump: The cimg/rust Docker image version has been incremented from 1.88.0 to 1.89.0, ensuring builds and tests run with the latest stable Rust toolchain.
Replace context.clone().compiler_settings.vyper with context.compiler_settings.vyper.clone() to avoid unnecessary cloning of the entire VerificationContext. This reduces memory allocations when creating VyperInput instances.
Applied to both etherscan and sourcify verification providers.
fix Automatic reruns provide a safety net for your CI/CD pipelines by automatically retrying failed steps and/or workflows. Automatic reruns help teams maintain productivity by reducing the need for manual intervention when steps and workflows fail due to temporary issues.
feat: add support for constructing tempo tx (feat: add support for constructing tempo tx foundry-rs/foundry#12972)
feat(anvil): basic tempo tx signing support (feat(anvil): basic tempo tx signing support foundry-rs/foundry#12974)
chore(meta): update .gitignore (chore(meta): update .gitignore foundry-rs/foundry#12975)
chore(deps): remove default features from tempo (chore(deps): remove default features from tempo foundry-rs/foundry#12976)
chore(deps): remove default features from tempo
serde
feat(cast): add tempo tx construction support (feat(cast): add tempo tx construction support foundry-rs/foundry#12973)
fix: use network-specific BaseFeeParams for Optimism in Anvil (fix: use network-specific BaseFeeParams for Optimism in Anvil foundry-rs/foundry#12944)
fix(forge): lookup path artifact if not in available artifacts (fix(forge): lookup path artifact if not in available artifacts foundry-rs/foundry#12927)
fix(forge): lookup artifact if not in available artifacts
EIP-4788 implementation
formatting
add beacon block root tests
Update crates/evm/evm/src/executors/trace.rs
Update crates/cast/src/cmd/run.rs
feat(cast): tempo nonce keys (feat(cast): tempo nonce keys foundry-rs/foundry#12977)
Update flake.lock (Update flake.lock foundry-rs/foundry#12979)
flake.lock: Update
Flake lock file updates:
• Updated input 'fenix':
'github:nix-community/fenix/3479aaf' (2025-12-27)
→ 'github:nix-community/fenix/e2b0f06' (2026-01-03) • Updated input 'fenix/rust-analyzer-src':
'github:rust-lang/rust-analyzer/8c5a68e' (2025-12-26)
→ 'github:rust-lang/rust-analyzer/e19dfc8' (2026-01-02) • Updated input 'nixpkgs':
'github:NixOS/nixpkgs/3edc4a3' (2025-12-27)
→ 'github:NixOS/nixpkgs/16c7794' (2026-01-02)
cargo update(chore(deps): weeklycargo updatefoundry-rs/foundry#12980)Updating git repository
https://github.com/rust-cli/rexpectUpdating git repository
https://github.com/paradigmxyz/solar.gitSkipping git submodule
https://github.com/argotorg/solidity.gitdue to update strategy in .gitmodulesUpdating git repository
https://github.com/tempoxyz/tempoUpdating git repository
https://github.com/paradigmxyz/rethLocking 23 packages to latest compatible versions
Unchanged annotate-snippets v0.12.5 (available: v0.12.10)
Unchanged anstyle-svg v0.1.11 (available: v0.1.12)
Updating base64ct v1.8.1 -> v1.8.2
Updating clap v4.5.53 -> v4.5.54
Updating clap_builder v4.5.53 -> v4.5.54
Updating clap_complete v4.5.62 -> v4.5.64
Adding darling v0.23.0
Adding darling_core v0.23.0
Adding darling_macro v0.23.0
Unchanged generic-array v0.14.7 (available: v0.14.9)
Updating handlebars v6.3.2 -> v6.4.0
Unchanged icu_collections v2.0.0 (available: v2.1.1)
Unchanged icu_normalizer v2.0.1 (available: v2.1.1)
Unchanged icu_normalizer_data v2.0.0 (available: v2.1.1)
Unchanged icu_properties v2.0.2 (available: v2.1.2)
Unchanged icu_properties_data v2.0.1 (available: v2.1.2)
Unchanged idna_adapter v1.1.0 (available: v1.2.1)
Updating instability v0.3.10 -> v0.3.11
Updating iri-string v0.7.9 -> v0.7.10
Updating libc v0.2.178 -> v0.2.179
Unchanged matchit v0.8.4 (available: v0.8.6)
Unchanged mdbook v0.4.52 (available: v0.5.2)
Updating openssl-probe v0.1.6 -> v0.2.0
Updating pest v2.8.4 -> v2.8.5
Updating pest_derive v2.8.4 -> v2.8.5
Updating pest_generator v2.8.4 -> v2.8.5
Updating pest_meta v2.8.4 -> v2.8.5
Unchanged protobuf v3.3.0 (available: v3.7.2)
Unchanged protobuf-support v3.3.0 (available: v3.7.2)
Unchanged rand v0.8.5 (available: v0.9.2)
Unchanged ratatui v0.29.0 (available: v0.30.0)
Unchanged reqwest v0.12.28 (available: v0.13.1)
Updating ruint v1.17.1 -> v1.17.2
Updating rustls-native-certs v0.8.2 -> v0.8.3
Updating syn v2.0.111 -> v2.0.113
Updating tokio v1.48.0 -> v1.49.0
Unchanged trezor-client v0.1.4 (available: v0.1.5)
Unchanged unicode-width v0.2.0 (available: v0.2.2)
Unchanged vergen v8.3.2 (available: v9.0.6)
Updating webpki-roots v1.0.4 -> v1.0.5
Updating zeroize_derive v1.4.2 -> v1.4.3
Updating zmij v1.0.0 -> v1.0.9
note: to see how you depend on a package, run
cargo tree --invert <dep>@<ver>Snyk has created this PR to upgrade @types/node from 24.10.4 to 25.0.2.
See this package in npm:
@types/node
See this project in Snyk:
https://app.snyk.io/org/dargon789/project/8da85645-409e-46fa-bd46-9b58e7905fb8?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr
docs: minor readme touchups (docs: minor readme touchups foundry-rs/foundry#12983)
chore(tests): bump forge-std version (chore(tests): bump forge-std version foundry-rs/foundry#12986)
chore: bump forge-std version used for tests
bump
fix brittle test, previously broke if there are commits after release and prior to ci run
fix gas cost
feat: alias
cast erc20 transfertocast erc20 send(feat: aliascast erc20 transfertocast erc20 sendfoundry-rs/foundry#12990)chore(tests): bump forge-std version (chore(tests): bump forge-std version foundry-rs/foundry#12992)
chore: bump forge-std version used for tests
bump
fix gas cost
feat(cast): add trace_transaction and trace_rawTransaction (feat(cast): add trace_transaction and trace_rawTransaction foundry-rs/foundry#12788)
add trace_transaction and trace_rawTransaction
add all trace_types
remove default trace [options] - record system behavior
trace record: record a trace file
$ trace record myworkload
[... Ctrl-C to stop ...]
$ trace record myworkload --Logging:enable-logs --end-after-duration 5s
$ trace record myworkload --plan profile --omit Symbolication
$ trace record myworkload --end-on-notification stop-myworkload-trace
[... elsewhere
notifyutil -p stop-myworkload-trace...]$ trace record /tmp/trace-path.atrc --compress
trace amend: add data to a file
$ trace amend myworkload-003.atrc --add Symbolication
trace trim: trim a file based on kdebug event times
$ trace trim myworkload-002.atrc --from +1s --to +2s
trace providers: print information about Logging, Symbolication, etc.
trace plans: print detailed information about tracing approaches
See
man tracefor more information. and instead errorcreate new trace.rs using traceextapi
chore: touchups
Bumps taiki-e/install-action from 2.65.7 to 2.65.13.
updated-dependencies:
Bumps taiki-e/cache-cargo-install-action from 2.3.1 to 3.0.0.
updated-dependencies:
Bumps oven-sh/setup-bun from 2.0.2 to 2.1.0.
updated-dependencies:
Bumps crate-ci/typos from 1.40.1 to 1.41.0.
updated-dependencies:
svm fails to download solc 0.8.33 on linux/arm64, bumpsvm-rs(fix:svm fails to download solc 0.8.33 on linux/arm64, bumpsvm-rsfoundry-rs/foundry#13007)bump svm-rs
svm fails to download solc 0.8.33 on linux/arm64, bumpsvm-rs(fix:svm fails to download solc 0.8.33 on linux/arm64, bumpsvm-rsfoundry-rs/foundry#13007) (Foundry/wagmi #309)bump svm-rs
Ethereumjs/master (Ethereumjs/master #310)
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Potential fix for code scanning alert no. 61: Workflow does not contain permissions
Potential fix for code scanning alert no. 74: Artifact poisoning
Create config.yml (Create config.yml #105)
Create cargo.yml (Create cargo.yml #106)
Delete .github/workflows/docker-image.yml
Rename ci_cargo.yml to cargo.yml
fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)
fix(fmt): account for ternary operators when estimating size
fix(fmt): handle comments between inherited base contracts
test: layout + base inheritance
Revert "fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)"
This reverts commit b8b5fbb.
CI/CD Configuration Update: The CircleCI configuration file, .circleci/cargo.yml, has been updated to use a newer version of the Rust Docker image.
Rust Toolchain Version Bump: The cimg/rust Docker image version has been incremented from 1.88.0 to 1.89.0, ensuring builds and tests run with the latest stable Rust toolchain.
This reverts commit 251a2b4.
https://github.com/apps/gemini-code-assist
Code Review
This pull request introduces a CircleCI workflow to automate formatting checks and tests. My review has identified two main issues in the configuration: redundant steps that would unnecessarily increase job execution time, and a mismatch between the Rust version in the CI environment and the one specified in the project's Cargo.toml. I've provided suggestions to fix these issues for a more efficient and consistent CI process.
Create docker.yml
Remove duplicate logic in TxSigner::address() implementations
fix(fmt): handle trailing coments between base contracts (Revert 142 master #296)
@0xrusowsky @Dargon789 fix(fmt): handle trailing coments between base contracts Revert 142 master (#296)
Create ci_cargo.yml (Create ci_cargo.yml #72)
Create config.yml
Rename ci_cargo.yml to cargo.yml
fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)
fix(fmt): account for ternary operators when estimating size
fix(fmt): handle comments between inherited base contracts
test: layout + base inheritance
Revert "fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)"
This reverts commit b8b5fbb.
CI/CD Configuration Update: The CircleCI configuration file, .circleci/cargo.yml, has been updated to use a newer version of the Rust Docker image.
Rust Toolchain Version Bump: The cimg/rust Docker image version has been incremented from 1.88.0 to 1.89.0, ensuring builds and tests run with the latest stable Rust toolchain.
Replace context.clone().compiler_settings.vyper with context.compiler_settings.vyper.clone() to avoid unnecessary cloning of the entire VerificationContext. This reduces memory allocations when creating VyperInput instances.
Applied to both etherscan and sourcify verification providers.
Forge/master (Forge/master #311)
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Potential fix for code scanning alert no. 61: Workflow does not contain permissions
Potential fix for code scanning alert no. 74: Artifact poisoning
Create config.yml (Create config.yml #105)
Create cargo.yml (Create cargo.yml #106)
Delete .github/workflows/docker-image.yml
Rename ci_cargo.yml to cargo.yml
fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)
fix(fmt): account for ternary operators when estimating size
fix(fmt): handle comments between inherited base contracts
test: layout + base inheritance
Revert "fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)"
This reverts commit b8b5fbb.
CI/CD Configuration Update: The CircleCI configuration file, .circleci/cargo.yml, has been updated to use a newer version of the Rust Docker image.
Rust Toolchain Version Bump: The cimg/rust Docker image version has been incremented from 1.88.0 to 1.89.0, ensuring builds and tests run with the latest stable Rust toolchain.
This reverts commit 251a2b4.
https://github.com/apps/gemini-code-assist
Code Review
This pull request introduces a CircleCI workflow to automate formatting checks and tests. My review has identified two main issues in the configuration: redundant steps that would unnecessarily increase job execution time, and a mismatch between the Rust version in the CI environment and the one specified in the project's Cargo.toml. I've provided suggestions to fix these issues for a more efficient and consistent CI process.
Introduce a basic CircleCI pipeline for the web3 GameFi project, providing a custom Docker executor and a stub job within a workflow.
CI:
Add CircleCI config file ci-web3-gamefi.yml with version 2.1 pipeline Define a custom executor using the cimg/base:stable Docker image with Docker Hub credentials Create a web3-defi-game-project- job and integrate it into a my-custom-workflow
Remove duplicate logic in TxSigner::address() implementations
fix(fmt): handle trailing coments between base contracts (Revert 142 master #296)
@0xrusowsky @Dargon789 fix(fmt): handle trailing coments between base contracts Revert 142 master (#296)
Create ci_cargo.yml (Create ci_cargo.yml #72)
Create config.yml
Rename ci_cargo.yml to cargo.yml
fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)
fix(fmt): account for ternary operators when estimating size
fix(fmt): handle comments between inherited base contracts
test: layout + base inheritance
Revert "fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)"
This reverts commit b8b5fbb.
CI/CD Configuration Update: The CircleCI configuration file, .circleci/cargo.yml, has been updated to use a newer version of the Rust Docker image.
Rust Toolchain Version Bump: The cimg/rust Docker image version has been incremented from 1.88.0 to 1.89.0, ensuring builds and tests run with the latest stable Rust toolchain.
Replace context.clone().compiler_settings.vyper with context.compiler_settings.vyper.clone() to avoid unnecessary cloning of the entire VerificationContext. This reduces memory allocations when creating VyperInput instances.
Applied to both etherscan and sourcify verification providers.
Update dev_stage.yml (Update dev_stage.yml #313) (Update dev_stage.yml (#313) #315)
Update dev_stage.yml (Update dev_stage.yml #313)
Update .circleci/dev_stage.yml
Foundry/main (Foundry/main #316)
chore(deps): bump the cargo group across 1 directory with 2 updates
Bumps the cargo group with 2 updates in the / directory: tracing-subscriber and ammonia.
Updates
tracing-subscriberfrom 0.3.19 to 0.3.20Updates
ammoniafrom 4.1.0 to 4.1.2updated-dependencies:
Update crates/verify/src/provider.rs
Update crates/doc/src/writer/as_doc.rs
Update as_doc.rs (Update as_doc.rs #235)
Tidy up formatting in as_doc.rs by removing extraneous blank lines in the Document::as_doc implementation
Enhancements:
Remove unnecessary blank line before initializing bases Remove unnecessary blank line before writing state variables
chore: ignore RUSTSEC (chore: ignore RUSTSEC foundry-rs/foundry#13011)
update deny for CI
Update more
chore(chisel): rm dead code (chore(chisel): rm dead code foundry-rs/foundry#13014)
chore(cli): rm dead code (chore(cli): rm dead code foundry-rs/foundry#13015)
chore(cheatcodes): rm dead code (chore(cheatcodes): rm dead code foundry-rs/foundry#13016)
chore(common): rm dead code (chore(common): rm dead code foundry-rs/foundry#13018)
chore(bench): rm dead code (chore(bench): rm dead code foundry-rs/foundry#13017)
fix(forge): respect lint ignore config in solar compilation (fix(forge): respect lint ignore config in solar compilation foundry-rs/foundry#12978)
fix: deduplicate submodule status check logic (fix: deduplicate submodule status check logic foundry-rs/foundry#13010)
Update mod.rs
chore: ignore RUSTSEC (chore: ignore RUSTSEC foundry-rs/foundry#13011)
update deny for CI
Update more
chore(chisel): rm dead code (chore(chisel): rm dead code foundry-rs/foundry#13014)
chore(cli): rm dead code (chore(cli): rm dead code foundry-rs/foundry#13015)
chore(cheatcodes): rm dead code (chore(cheatcodes): rm dead code foundry-rs/foundry#13016)
chore(common): rm dead code (chore(common): rm dead code foundry-rs/foundry#13018)
chore(bench): rm dead code (chore(bench): rm dead code foundry-rs/foundry#13017)
fix(forge): respect lint ignore config in solar compilation (fix(forge): respect lint ignore config in solar compilation foundry-rs/foundry#12978)
fix: deduplicate submodule status check logic (fix: deduplicate submodule status check logic foundry-rs/foundry#13010)
Update mod.rs
refactor(lint): extract duplicate help formatting logic (refactor(lint): extract duplicate help formatting logic foundry-rs/foundry#13020)
Update mod.rs
Update mod.rs
Foundry/ethereum ux fix tempo Revert 142 master #296 (Foundry/ethereum ux fix tempo #296 #319)
Potential fix for code scanning alert no. 19: Workflow does not contain permissions
Potential fix for code scanning alert no. 61: Workflow does not contain permissions
Potential fix for code scanning alert no. 74: Artifact poisoning
Create config.yml (Create config.yml #105)
Create cargo.yml (Create cargo.yml #106)
Delete .github/workflows/docker-image.yml
Rename ci_cargo.yml to cargo.yml
fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)
fix(fmt): account for ternary operators when estimating size
fix(fmt): handle comments between inherited base contracts
test: layout + base inheritance
Revert "fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)"
This reverts commit b8b5fbb.
CI/CD Configuration Update: The CircleCI configuration file, .circleci/cargo.yml, has been updated to use a newer version of the Rust Docker image.
Rust Toolchain Version Bump: The cimg/rust Docker image version has been incremented from 1.88.0 to 1.89.0, ensuring builds and tests run with the latest stable Rust toolchain.
This reverts commit 251a2b4.
https://github.com/apps/gemini-code-assist
Code Review
This pull request introduces a CircleCI workflow to automate formatting checks and tests. My review has identified two main issues in the configuration: redundant steps that would unnecessarily increase job execution time, and a mismatch between the Rust version in the CI environment and the one specified in the project's Cargo.toml. I've provided suggestions to fix these issues for a more efficient and consistent CI process.
Remove duplicate logic in TxSigner::address() implementations
fix(fmt): handle trailing coments between base contracts (Revert 142 master #296)
@0xrusowsky @Dargon789 fix(fmt): handle trailing coments between base contracts Revert 142 master (#296)
Create ci_cargo.yml (Create ci_cargo.yml #72)
Create config.yml
Rename ci_cargo.yml to cargo.yml
fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)
fix(fmt): account for ternary operators when estimating size
fix(fmt): handle comments between inherited base contracts
test: layout + base inheritance
Revert "fix(fmt): handle trailing coments between base contracts (fix(fmt): handle trailing coments between base contracts foundry-rs/foundry#12127)"
This reverts commit b8b5fbb.
CI/CD Configuration Update: The CircleCI configuration file, .circleci/cargo.yml, has been updated to use a newer version of the Rust Docker image.
Rust Toolchain Version Bump: The cimg/rust Docker image version has been incremented from 1.88.0 to 1.89.0, ensuring builds and tests run with the latest stable Rust toolchain.
Replace context.clone().compiler_settings.vyper with context.compiler_settings.vyper.clone() to avoid unnecessary cloning of the entire VerificationContext. This reduces memory allocations when creating VyperInput instances.
Applied to both etherscan and sourcify verification providers.
chore(evm): deprecate RawCallResult::from_execution_result (chore(evm): deprecate RawCallResult::from_execution_result foundry-rs/foundry#13012)
chore(evm): deprecate RawCallResult::from_execution_result
remove
RawCallResult::from_execution_resultcompletelychore(anvil): rm dead code (chore(anvil): rm dead code foundry-rs/foundry#13019)
refactor: remove dead CheatsConfig fields and allocations (refactor: remove dead CheatsConfig fields and allocations foundry-rs/foundry#13031)
chore: remove dead code (chore: remove dead code foundry-rs/foundry#13030)
chore(anvil): remove
anvil_getBlobSidecarsByBlockIdendpoint (chore(anvil): removeanvil_getBlobSidecarsByBlockIdendpoint foundry-rs/foundry#13022)feat: uncomment transaction replacement test (feat: uncomment transaction replacement test foundry-rs/foundry#13029)
feat: uncomment transaction replacement test after alloy fix
fix compile issue
removed the attempt to get receipt for the replaced transaction since it never gets mined.
perf: remove redundant allocation in receipt bloom calculation (perf: remove redundant allocation in receipt bloom calculation foundry-rs/foundry#13035)
Update receipt.rs
wallet: delegate TxSigner::address() to Signer::address() (wallet: delegate TxSigner::address() to Signer::address() foundry-rs/foundry#12948)
Remove duplicate logic in TxSigner::address() implementations
expend to sign_transaction
use delegate
chore: update alloy (chore: update alloy foundry-rs/foundry#12994)
update alloy
chore: bump alloy and remove RUSTSEC-2024-0437 (chore: bump alloy and remove RUSTSEC-2024-0437 foundry-rs/foundry#12995)
chore: remove RUSTSEC-2024-0437
chore: bump release deps
chore: fmt
chore: remove lru advisory
chore: add lru advisory
chore: bump ratatui to remove lru ignore rustsec
Pin ni…
Motivation
Solution
PR Checklist