Prevent invalid projectId placement in Luna task creation - #12
Open
FMnaga wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Luna task-lane contract requires selecting a project but does not show that
projectIdbelongs insidetarget. This leaves room for a top-levelprojectId, which the currentcreate_threadschema rejects before task creation.Changes
create_threadargument example.projectIdis invalid.verify.shand fail if target nesting, worktree routing, Luna/Max, or the packet placeholder drifts.Verification
missing canonical create_thread project argumentsbefore the contract update.sh -n plugins/sol-advisor/scripts/verify.shpassed in an LF checkout.git diff --check origin/main..HEADpassed.The full repository
verify.shcurrently stops onFAIL: manifest does not describe app-task routing; the same failure reproduces unchanged on upstreammainat154fd7a, before this patch.