Add GitHub star banner and theme preference functionality - #3
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; | ||
| background-color: #f8fafc; | ||
| background-color: var(--color-background); |
There was a problem hiding this comment.
CSS variable undefined at body element scope
Medium Severity
The body element's background-color now uses var(--color-background), but this CSS variable is scoped to the Radix Theme component, which is a descendant of body. Since CSS variables cascade down to children but not up to parents, --color-background is undefined at the body level. This causes the body background to use the browser default instead of the theme color, breaking the dark mode background and regressing from the previous hardcoded #f8fafc value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds theme customization and a small promotional banner, plus minor UI polish.
system/light/darktheme preference with localStorage persistence and system color-scheme detection; applies via RadixThemeappearanceSunIcon,MoonIcon,DesktopIcon,CheckIcon) to switch themesvar(--color-background)InvoiceForm; minor layout tweaks@radix-ui/react-iconsdependencyWritten by Cursor Bugbot for commit c64435b. This will update automatically on new commits. Configure here.