Personal Targeted Spells: honor raid vs party settings#167
Open
Krathe82 wants to merge 2 commits into
Open
Conversation
…arty) The whole personal-targeted runtime resolved its db with DF:GetDB() (party), so in a raid it ignored the raid enable toggle / size / position / border and used the party settings instead — showing the icon in raid when it was disabled on the raid tab. Added GetPersonalDB() (IsInRaid() and GetRaidDB() or GetDB()) and routed the personal path through it: the enable gate (ProcessCastInternal, HandleTargetChange, HandleCastStop, InitTargetedSpells) and every Personal* layout/show/border function. The group-frame and Targeted List paths stay party-resolved by design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: with Personal Targeted Spells disabled on the raid tab (and enabled on party), the icon still showed in raid.
Cause: the entire personal-targeted runtime resolved its settings with
DF:GetDB()(always the party DB) — the enable gate (ProcessCastInternal,HandleTargetChange,HandleCastStop,InitTargetedSpells) and everyPersonal*layout/show/border function. So in a raid it read the party enable toggle (and party size / position / border), ignoring the raid tab entirely. The feature stores settings per-mode (the options page is mode-split, andNeedsCastEventsalready checks bothdb.partyanddb.raid), so the runtime was simply reading the wrong one.Fix: added a small resolver
and routed the personal-targeted path through it. The group-frame and Targeted List paths stay party-resolved by design (group targeted is party-only; the list is party-only).
Net effect: in raid it honors the raid tab (enable + size/position/border); in party, party.
Note: touches
TargetedSpells.lua, which #164 also edits — they don't appear to overlap on the same lines, but worth merging this after #164 to be safe. Not luac-verified (none available); validated in-game.